fail the workflow till there are lint issues

mdn · Aug 1, 2023 · ef19e6b · ef19e6b
1 parent fdd3794
commit ef19e6b
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/.github/workflows/pr-review-lint.yml b/.github/workflows/pr-review-lint.yml
@@ -69,6 +69,10 @@ jobs:
           echo "Running Prettier"
           yarn prettier -w ${files_to_lint}
 
+          if [[ -n $(git diff) || "${MD_LINT_STATUS}" == "1" || "${FM_LINT_STATUS}" == "1" ]]; then
+            echo "CHANGES_REQUIRED=true" >> $GITHUB_ENV
+          fi
+
       - name: Setup reviewdog
         uses: reviewdog/action-setup@v1
         with:
@@ -105,3 +109,9 @@ jobs:
         run: |
           echo "${{ env.FM_LINT_LOG }}"
           exit 1
+
+      - name: Fail till changes are pending
+        if: env.CHANGES_REQUIRED == 'true'
+        run: |
+          echo "Please fix all the linting issues suggested in the review comments."
+          exit 1