Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FF116 Audio Output Device API updates #27818
FF116 Audio Output Device API updates #27818
Changes from 16 commits
22ccc35
43efef4
35be586
2faa468
6f0055d
c86984b
291194c
08ce0df
1de7de8
81e5a03
f9eae21
bc4044b
350eb9d
648380a
f0f0d71
3602649
2dc0345
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not in your PR, but I think we need a better way of talking about "exceptions" for functions that return promises, because presumably these exceptions aren't thrown (unless the function is called with
await
) but rather the promise rejects with them.So maybe after
### Exceptions
we should say something like "The returned promise may reject with any of the following excepotions"? I wonder if @teoli2003 has an opinion on this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have been avoiding this question by just listing the exceptions - not "this exception will be thrown" or "promise will be rejected with this exception". I see this as less wrong that either of the above options, but that's just an opinion.
We should have a decision and standard words on this - raise a discussion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI @wbamberg This is updated explanation of what it means to persist a device id