Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document HTMLAllCollection #27974

Merged
merged 4 commits into from
Aug 5, 2023
Merged

Document HTMLAllCollection #27974

merged 4 commits into from
Aug 5, 2023

Conversation

Josh-Cena
Copy link
Member

Description

Fix #25178

First time writing Web API docs. Please advise.

Motivation

Additional details

Related issues and pull requests

@Josh-Cena Josh-Cena requested a review from a team as a code owner July 16, 2023 09:07
@Josh-Cena Josh-Cena requested review from Elchi3 and removed request for a team July 16, 2023 09:07
@github-actions github-actions bot added the Content:WebAPI Web API docs label Jul 16, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 16, 2023

Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Josh-Cena !

I had some comments, and questions. I suppose it's questionable how much time we should put into perfecting these pages on this deprecated and terrible API.

files/en-us/web/api/htmlallcollection/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/htmlallcollection/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/htmlallcollection/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/htmlallcollection/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/htmlallcollection/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/htmlallcollection/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/htmlallcollection/item/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/htmlallcollection/item/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/htmlallcollection/nameditem/index.md Outdated Show resolved Hide resolved
@Josh-Cena Josh-Cena requested a review from wbamberg August 5, 2023 01:20
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you @Josh-Cena !

@wbamberg wbamberg merged commit e8e22a6 into mdn:main Aug 5, 2023
6 checks passed
@Josh-Cena Josh-Cena deleted the document-all branch August 5, 2023 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing HTMLAllCollection
2 participants