Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wasm): Upgrade WASM node tutorial to use node 20 #28048

Merged
merged 9 commits into from
Jan 11, 2024

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Jul 19, 2023

Fixes #27989

  • Target node 20
  • Upgrade packages in package.json
  • add experiments: {asyncWebAssembly: true,} to webpack config
  • minor update to path as http://localhost:8080 alone won't show the index added copy-webpack-plugin

other changes:

  • highlight which index.html file is new

tests:
I ran through this tutorial recently, so I can confirm following the steps worked well with Node 16, but this is EOL soon. Ran this locally, works as expected:

image

@bsmth bsmth requested a review from a team as a code owner July 19, 2023 12:39
@bsmth bsmth requested review from hamishwillee and removed request for a team July 19, 2023 12:39
@github-actions github-actions bot added the Content:wasm WebAssembly docs label Jul 19, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 19, 2023

Preview URLs

External URLs (6)

URL: /en-US/docs/WebAssembly/Rust_to_Wasm
Title: Compiling from Rust to WebAssembly

(comment last updated: 2024-01-11 17:16:01)

@hamishwillee
Copy link
Collaborator

I don't feel particularly expert in this. @Josh-Cena are you reviewing testing this? If not then I'll put some effort in.

@Josh-Cena
Copy link
Member

I'm not particularly familiar with Webpack either. LGTM at a glance but would appreciate some tests

@bsmth
Copy link
Member Author

bsmth commented Aug 22, 2023

LGTM at a glance but would appreciate some tests

Should I put the example code in a repo somewhere?

@bsmth
Copy link
Member Author

bsmth commented Aug 23, 2023

Example code checked in here if you would like to try it out: mdn/webassembly-examples#33

@bsmth
Copy link
Member Author

bsmth commented Aug 31, 2023

Hi @Josh-Cena - just an FYI there's a demo checked in here for a sanity check on these changes: https://github.com/bsmth/webassembly-examples/tree/wasm-node/rust-node

@Josh-Cena
Copy link
Member

Sorry, I don't have the capacity to actually review this. Would be great if @hamishwillee can help

@bsmth
Copy link
Member Author

bsmth commented Sep 6, 2023

Sorry, I don't have the capacity to actually review this.

Not a problem, thanks for the heads up!

@hamishwillee
Copy link
Collaborator

I will have the capacity one day, but not until I have cleared my FF queue - it's "non core". YOu can keep pinging me or find someone else. I am keeping it on my list though.

@bsmth bsmth requested a review from a team as a code owner January 10, 2024 10:28
@bsmth bsmth requested review from dipikabh and removed request for a team January 10, 2024 10:28
@github-actions github-actions bot added the system [PR only] Infrastructure and configuration for the project label Jan 10, 2024
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've only done a quick language proofread and it looks good overall 👍
Leaving my +1.

Thank you for updating these docs!!

files/en-us/webassembly/rust_to_wasm/index.md Show resolved Hide resolved
files/en-us/webassembly/rust_to_wasm/index.md Outdated Show resolved Hide resolved
files/en-us/webassembly/rust_to_wasm/index.md Outdated Show resolved Hide resolved
files/en-us/webassembly/rust_to_wasm/index.md Outdated Show resolved Hide resolved
Co-authored-by: Dipika Bhattacharya <[email protected]>
@bsmth
Copy link
Member Author

bsmth commented Jan 11, 2024

Thank you!

@bsmth bsmth merged commit 4a3f5b6 into mdn:main Jan 11, 2024
7 checks passed
@bsmth bsmth deleted the 27989-rust-to-wasm-node-20 branch January 11, 2024 17:19
dipikabh added a commit to dipikabh/content that referenced this pull request Jan 17, 2024
* feat(wasm): Upgrade WASM node tutorial to use node 20

* Update files/en-us/webassembly/rust_to_wasm/index.md

* feat(wasm): update Node WASM tutorial

* chore: update deps, install from local pkg

* chore: pin major versions of dev deps

* Apply suggestions from code review

Co-authored-by: Dipika Bhattacharya <[email protected]>

---------

Co-authored-by: Dipika Bhattacharya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:wasm WebAssembly docs system [PR only] Infrastructure and configuration for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rust to Wasm Node 20
4 participants