-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wasm): Upgrade WASM node tutorial to use node 20 #28048
Conversation
Preview URLs External URLs (6)URL:
(comment last updated: 2024-01-11 17:16:01) |
I don't feel particularly expert in this. @Josh-Cena are you reviewing testing this? If not then I'll put some effort in. |
I'm not particularly familiar with Webpack either. LGTM at a glance but would appreciate some tests |
Should I put the example code in a repo somewhere? |
Example code checked in here if you would like to try it out: mdn/webassembly-examples#33 |
Hi @Josh-Cena - just an FYI there's a demo checked in here for a sanity check on these changes: https://github.com/bsmth/webassembly-examples/tree/wasm-node/rust-node |
Sorry, I don't have the capacity to actually review this. Would be great if @hamishwillee can help |
Not a problem, thanks for the heads up! |
I will have the capacity one day, but not until I have cleared my FF queue - it's "non core". YOu can keep pinging me or find someone else. I am keeping it on my list though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've only done a quick language proofread and it looks good overall 👍
Leaving my +1.
Thank you for updating these docs!!
Co-authored-by: Dipika Bhattacharya <[email protected]>
Thank you! |
* feat(wasm): Upgrade WASM node tutorial to use node 20 * Update files/en-us/webassembly/rust_to_wasm/index.md * feat(wasm): update Node WASM tutorial * chore: update deps, install from local pkg * chore: pin major versions of dev deps * Apply suggestions from code review Co-authored-by: Dipika Bhattacharya <[email protected]> --------- Co-authored-by: Dipika Bhattacharya <[email protected]>
Fixes #27989
experiments: {asyncWebAssembly: true,}
to webpack configminor update to path asadded copy-webpack-pluginhttp://localhost:8080
alone won't show the indexother changes:
tests:
I ran through this tutorial recently, so I can confirm following the steps worked well with Node 16, but this is EOL soon. Ran this locally, works as expected: