Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Module: CSS Selectors #28062
New Module: CSS Selectors #28062
Changes from 33 commits
c2e2ea4
9911797
93aa559
40246e9
4acea89
2743f9b
f8c56f9
0d24bfe
5f0e1fa
28325d9
4fbdb17
1070d8d
076e923
b2f60b8
557bd0c
037b3dc
ac21e9c
c2fed1d
30be86d
a3ac2e7
8bb4278
97aebbc
40bb6b6
508dd33
e21f3d0
e15116b
05f1594
31e6950
11d866d
044e850
dd8b38b
b10ad6d
7e0857d
08ce023
5e74c44
987449a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### Selectors
?### Selectors
(Attribute to Universal bullets) and then### Pseudo-class selectors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these both seem to be the same page so maybe have just one entry?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we have this here, it is not really a guide? We have it covered in the previous list. Also we are not listing other selector types here in the Guides section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment - do we need to list it here? We have it covered in the previous list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kept pseudo and expanded the explaination
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move this to after "CSS selector structure"? That way all of the pages under "CSS_selectors" will be listed together followed by all the Learn guides.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this wasn't so unrelated it would make sense, but I am unclear why target is where it is.