Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): Fix macro-related flaws in the template files #28066

Merged
merged 8 commits into from
Jul 27, 2023

Conversation

dipikabh
Copy link
Contributor

Description

The {{Specifications}}, {{Compat}}, {{domxref()}}, and {{svginfo}} macros in template pages are calling on pages that do not exist because the page names are variables being used as examples. These are leading to macro flaws (for example, Specifications and Browser compatibility sections in the API constructor subpage template).

This PR edits the macro calls to escape the macro string and also adds text to say how to use the macro when editing the markdown file while authoring.

This PR also makes a few minor edits on template pages.

Motivation

Fix macro flaws

@dipikabh dipikabh requested a review from a team as a code owner July 20, 2023 01:55
@dipikabh dipikabh requested review from Elchi3 and removed request for a team July 20, 2023 01:55
@github-actions github-actions bot added the Content:Meta Content in the meta docs label Jul 20, 2023
@bsmth bsmth self-assigned this Jul 26, 2023
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dipikabh - merging shortly 👍🏻

@bsmth bsmth merged commit dad6b0e into mdn:main Jul 27, 2023
6 checks passed
@dipikabh dipikabh deleted the templates branch September 7, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Meta Content in the meta docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants