Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add slot tag to flow content list #28083

Merged
merged 3 commits into from
Jul 20, 2023

Conversation

ir3ne
Copy link
Contributor

@ir3ne ir3ne commented Jul 20, 2023

Description

Closes: #27991

Motivation

Additional details

Related issues and pull requests

@ir3ne ir3ne requested a review from a team as a code owner July 20, 2023 14:48
@ir3ne ir3ne requested review from estelle and removed request for a team July 20, 2023 14:48
@github-actions github-actions bot added the Content:HTML Hypertext Markup Language docs label Jul 20, 2023
@Josh-Cena
Copy link
Member

Not a blocker, but could you add the other changes I suggested in #27991?

  • <bdi> is phrasing
  • <a> is interactive only if href is present
  • <dialog> is flow
  • <search> is flow
  • Text is flow

@ir3ne
Copy link
Contributor Author

ir3ne commented Jul 20, 2023

@Josh-Cena added.

Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made some edits myself. FYI:

  • When I say "text" I mean "text", not <text> (you could tell from my formatting).
  • Location.href and HTMLAnchorElement.href are different, and both are different from the HTML href attribute. We don't link from HTML to the IDL attribute.

@github-actions
Copy link
Contributor

Preview URLs

@Josh-Cena Josh-Cena merged commit 62681c2 into mdn:main Jul 20, 2023
6 checks passed
@Josh-Cena
Copy link
Member

Thank you, and welcome to MDN :)

@ir3ne
Copy link
Contributor Author

ir3ne commented Jul 20, 2023

@Josh-Cena thanks for the explanation 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:HTML Hypertext Markup Language docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<slot> missing from Flow content element list
2 participants