Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'constituent properties' section to all shorthand properties #28088

Merged
merged 4 commits into from
Jul 24, 2023

Conversation

wbamberg
Copy link
Collaborator

@wbamberg wbamberg commented Jul 20, 2023

Shorthand properties should have a "Constituent properties" section. This PR adds the section for all shorthand properties that were missing one.

I also moved the description in https://developer.mozilla.org/en-US/docs/Web/CSS/overscroll-behavior into its own section.

@wbamberg wbamberg requested a review from a team as a code owner July 20, 2023 21:45
@wbamberg wbamberg requested review from dipikabh and removed request for a team July 20, 2023 21:45
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Jul 20, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 20, 2023

Preview URLs (6 pages)
Flaws (6)

Note! 5 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/-webkit-border-before
Title: -webkit-border-before
Flaw count: 6

  • macros:
    • /en-US/docs/Web/CSS/-webkit-border-before-color does not exist
    • /en-US/docs/Web/CSS/-webkit-border-before-style does not exist
    • /en-US/docs/Web/CSS/-webkit-border-before-width does not exist
    • /en-US/docs/Web/CSS/-webkit-border-after does not exist
    • /en-US/docs/Web/CSS/-webkit-border-start does not exist
    • and 1 more flaws omitted

(comment last updated: 2023-07-20 22:46:27)

@dipikabh dipikabh self-assigned this Jul 20, 2023
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the missing section to these pages, @wbamberg!

The addition itself is good. I've indicated some minor edits to other impacted text.

- {{cssxref("-webkit-border-before-color")}}
- {{cssxref("-webkit-border-before-style")}}
- {{cssxref("-webkit-border-before-width")}}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This update itself is good.

But all the text after the Syntax block might need to be reconsidered.

  • This sentence can be deleted: "-webkit-border-before can be used to set the values for one or more of: {{cssxref("-webkit-border-before-width")}}, {{cssxref("-webkit-border-before-style")}}, and {{cssxref("-webkit-border-before-color")}}."
  • "It maps to" could then be "The -webkit-border-before property maps to..."
  • Not in the scope of this PR but mentioning nevertheless:
    • I don't understand why we have three sentences with "It maps to...", "It corresponds to..", and "It relates to...".
    • "This property is on the standard track..." but the page has the "Non-standard" banner.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some of these edits, and also moved the syntax code block to the right place and most of the prose into ## Description.

I don't understand why we have three sentences with "It maps to...", "It corresponds to..", and "It relates to...".

Yeah, I agree this is a bit sloppy. I think the idea is: the physical border that it sets (i.e. top, right, bottom, or left) is dependent on writing direction. So it sets the border at the "start", whichever is considered the start for the given writing direction. So in LTR text, it will set the left border, but in RTL it will set the right border.

But I basically failed to think of better text for this now, and I'm happy to call it out of scope for this PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The edit is cleaner and reads better now. Thank you! Thanks also for fixing the "standards track" statement. :)

files/en-us/web/css/overscroll-behavior/index.md Outdated Show resolved Hide resolved
wbamberg and others added 3 commits July 20, 2023 15:17
… css-shorthand-constituents

* origin/css-shorthand-constituents:
  Update files/en-us/web/css/overscroll-behavior/index.md
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, Will! 👍

@dipikabh dipikabh merged commit 9e52172 into mdn:main Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants