-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'constituent properties' section to all shorthand properties #28088
Conversation
Preview URLs (6 pages)Flaws (6)Note! 5 documents with no flaws that don't need to be listed. 🎉 URL:
(comment last updated: 2023-07-20 22:46:27) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the missing section to these pages, @wbamberg!
The addition itself is good. I've indicated some minor edits to other impacted text.
- {{cssxref("-webkit-border-before-color")}} | ||
- {{cssxref("-webkit-border-before-style")}} | ||
- {{cssxref("-webkit-border-before-width")}} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This update itself is good.
But all the text after the Syntax block might need to be reconsidered.
- This sentence can be deleted: "
-webkit-border-before
can be used to set the values for one or more of: {{cssxref("-webkit-border-before-width")}}, {{cssxref("-webkit-border-before-style")}}, and {{cssxref("-webkit-border-before-color")}}." - "It maps to" could then be "The
-webkit-border-before
property maps to..." - Not in the scope of this PR but mentioning nevertheless:
- I don't understand why we have three sentences with "It maps to...", "It corresponds to..", and "It relates to...".
- "This property is on the standard track..." but the page has the "Non-standard" banner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some of these edits, and also moved the syntax code block to the right place and most of the prose into ## Description
.
I don't understand why we have three sentences with "It maps to...", "It corresponds to..", and "It relates to...".
Yeah, I agree this is a bit sloppy. I think the idea is: the physical border that it sets (i.e. top, right, bottom, or left) is dependent on writing direction. So it sets the border at the "start", whichever is considered the start for the given writing direction. So in LTR text, it will set the left border, but in RTL it will set the right border.
But I basically failed to think of better text for this now, and I'm happy to call it out of scope for this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The edit is cleaner and reads better now. Thank you! Thanks also for fixing the "standards track" statement. :)
Co-authored-by: Dipika Bhattacharya <[email protected]>
… css-shorthand-constituents * origin/css-shorthand-constituents: Update files/en-us/web/css/overscroll-behavior/index.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, Will! 👍
Shorthand properties should have a "Constituent properties" section. This PR adds the section for all shorthand properties that were missing one.
I also moved the description in https://developer.mozilla.org/en-US/docs/Web/CSS/overscroll-behavior into its own section.