Use IP addresses from documentation ranges cf. rfc5737 #28135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SphinxKnight
requested review from
jpmedley,
sideshowbarker and
teoli2003
and removed request for
a team
github-actions
bot
added
Content:WebExt
bsmth
reviewed
Jul 24, 2023
bsmth
reviewed
Jul 24, 2023
files/en-us/learn/common_questions/web_mechanics/what_is_a_domain_name/index.md
Show resolved
Hide resolved
bsmth
approved these changes
Jul 24, 2023
sideshowbarker
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing some updates in the French section, I noticed that some IP addresses in the docs were not from reserved ranges.
Description
I changed existing IP addresses to reserved IP addresses for documentation
Motivation
https://datatracker.ietf.org/doc/html/rfc5737
Additional details
I may have been too "strict" for some articles and also have voluntarily left some mentions of non-reserved IP addresses when I felt they deserved to be kept in the documentation due to their nature (ex. ping mozilla.org…)
Reviewers may use the following regexp
(\d{1,3})\.(\d{1,3})\.(\d{1,3})\.(\d{1,3})to look for IPv4 addresses. I used[0-9a-f]{1,4}:[0-9a-f]{1,4}:[0-9a-f]{1,4}:[0-9a-f]{1,4}:[0-9a-f]{1,4}:[0-9a-f]{1,4}:[0-9a-f]{1,4}:[0-9a-f]{1,4}for IPv6 but the existing occurrences wee fine.https://en.wikipedia.org/wiki/Reserved_IP_addresses may be friendlier than the RFC if needed