CycleTracker Tutorial Proofread: Introduction #28137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I moved the list after the colon to avoid using two colons in one sentence.
To me, "Store App" feels like a typo, even though it may not be.
My gut feeling says the folder isn't owned by the applications—but I could be wrong.
|
Preview URLs External URLs (2)URL:
(comment last updated: 2023-07-23 22:41:36) |
| @@ -43,15 +44,15 @@ Once installed, PWAs can be made to appear and act similarly to other applicatio | |||
|
|
|||
| - Application icon | |||
|
|
|||
| - : PWAs display an application icon in the same location as other installed applications installed on the users' operating system. This can be an icon on the homescreen, in the toolbar, in the application's folder, or wherever the device displays application icons. We'll learn how to [declare icons](/en-US/docs/Web/Progressive_web_apps/Tutorials/CycleTracker/Manifest_file#app_iconography) for CycleTracker, so, once installed, our PWA can appear like any other installed application on the user's device. | |||
| - : PWAs display an application icon in the same location as other installed applications installed on the users' operating system. This can be an icon on the homescreen, in the toolbar, in the applications folder, or wherever the device displays application icons. We'll learn how to [declare icons](/en-US/docs/Web/Progressive_web_apps/Tutorials/CycleTracker/Manifest_file#app_iconography) for CycleTracker, so, once installed, our PWA can appear like any other installed application on the user's device. | |||
There was a problem hiding this comment.
Reverting on assumption that this refers to the the folder belonging to the application and not a folder named "Applications".
Suggested change
| - : PWAs display an application icon in the same location as other installed applications installed on the users' operating system. This can be an icon on the homescreen, in the toolbar, in the applications folder, or wherever the device displays application icons. We'll learn how to [declare icons](/en-US/docs/Web/Progressive_web_apps/Tutorials/CycleTracker/Manifest_file#app_iconography) for CycleTracker, so, once installed, our PWA can appear like any other installed application on the user's device. | |
| - : PWAs display an application icon in the same location as other installed applications installed on the users' operating system. This can be an icon on the homescreen, in the toolbar, in the application's folder, or wherever the device displays application icons. We'll learn how to [declare icons](/en-US/docs/Web/Progressive_web_apps/Tutorials/CycleTracker/Manifest_file#app_iconography) for CycleTracker, so, once installed, our PWA can appear like any other installed application on the user's device. |
There was a problem hiding this comment.
Hmm. @hamishwillee, I was thinking of something like MacOS's "Applications" folder where the icon of each app is shown. I imagined that was a more likely scenario than the user seeing the application's icon in the application's folder; that seems like a place a developer, but not an end-user would visit. Have I misunderstood which folder you're referring to, maybe?
I'd welcome any other thoughts you have on the matter.
There was a problem hiding this comment.
We're both making assumptions about what folder the author was thinking about. Unless we know for sure, not worth changing.
files/en-us/web/progressive_web_apps/tutorials/cycletracker/index.md
Outdated
Show resolved
Hide resolved
hamishwillee
approved these changes
Jul 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm a technical writer by education, so I figured I'd lend a hand while I followed this tutorial.
Description
Fixing a few small typographical mistakes, leaving the tutorial clearer.
Motivation
To smooth out any bumps that might otherwise give readers unnecessary pause.
Additional details
To keep things manageable, I'll submit multiple PRs instead of one big one.
Related issues and pull requests