Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New module: CSS pseudo-elements #28153

Merged
merged 17 commits into from
Jul 26, 2023
Merged

New module: CSS pseudo-elements #28153

merged 17 commits into from
Jul 26, 2023

Conversation

estelle
Copy link
Member

@estelle estelle commented Jul 24, 2023

The CSS selectors module has been divided into two modules: selectors and pseudo. This adds the pseudo module.

::prefix and ::postfix are at risk, and not implemented, so I did not include them.

@estelle estelle requested a review from a team as a code owner July 24, 2023 17:41
@estelle estelle requested review from chrisdavidmills and removed request for a team July 24, 2023 17:41
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Jul 24, 2023
@estelle estelle requested a review from dipikabh July 24, 2023 17:42
@github-actions
Copy link
Contributor

github-actions bot commented Jul 24, 2023 •
edited
Loading

Preview URLs (6 pages)
Flaws (2)

Note! 4 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/CSS_pseudo-elements
Title: CSS pseudo-elements
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_Selectors/selectors_and_combinators#combinators

URL: /en-US/docs/Web/CSS/CSS_selectors/Selector_structure
Title: CSS selector structure
Flaw count: 1

  • macros:
    • /en-US/docs/Web/CSS/is does not exist

(comment last updated: 2023-07-26 07:13:58)

@dipikabh dipikabh self-assigned this Jul 24, 2023
@dipikabh
Copy link
Contributor

Taking a look at this now

dipikabh
dipikabh requested changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @estelle for adding this module landing page! 🙌

files/en-us/web/css/css_pseudo/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_pseudo/index.md Outdated

{{CSSRef}}

The **CSS pseudo-element** module defines the patterns representing entities not included in HTML.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the phrase from the https://developer.mozilla.org/en-US/docs/Web/CSS/Pseudo-elements page so that the description on the two pages about pseudo-elements is not vastly different.

Suggested change
The **CSS pseudo-element** module defines the patterns representing entities not included in HTML.
The **CSS pseudo-elements** module provides keywords you can add to selectors to style a specific part of the selected element(s). The patterns defined in this module represent entities not included in HTML.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to update the pseudo page.

Copy link
Member Author

@estelle estelle Jul 26, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rewrote the intro on this page. will update https://developer.mozilla.org/en-US/docs/Web/CSS/Pseudo-elements in a different PR

files/en-us/web/css/css_pseudo/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_pseudo/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_pseudo/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_pseudo/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_pseudo/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_pseudo/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_pseudo/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_pseudo/index.md Outdated Show resolved Hide resolved
@github-actions github-actions bot added the merge conflicts 🚧 [PR only] label Jul 25, 2023
@github-actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 [PR only] label Jul 26, 2023
@estelle estelle requested a review from dipikabh July 26, 2023 00:50
dipikabh
dipikabh requested changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few edits in the rewritten intro paras. Let me know what you think.

@estelle estelle requested a review from dipikabh July 26, 2023 07:12
dipikabh
dipikabh approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, @estelle!

@dipikabh dipikabh merged commit ceb7507 into mdn:main Jul 26, 2023
6 checks passed
@estelle estelle deleted the pseudo branch August 3, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipikabh dipikabh dipikabh approved these changes

@chrisdavidmills chrisdavidmills Awaiting requested review from chrisdavidmills chrisdavidmills is a code owner automatically assigned from mdn/yari-content-css

Assignees

@dipikabh dipikabh

Labels
Content:CSS Cascading Style Sheets docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@estelle @dipikabh