Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set code languages for various files (part 3) #28159

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Set code languages for various files (part 3) #28159

merged 1 commit into from
Jul 24, 2023

Conversation

queengooborg
Copy link
Collaborator

This PR sets the code language for various codeblocks that don't have one set, which will help us enforce setting a language on all codeblocks. This is the third part.

@queengooborg queengooborg requested review from a team as code owners July 24, 2023 23:42
@queengooborg queengooborg requested review from fred-wang, Josh-Cena and hamishwillee and removed request for a team July 24, 2023 23:42
@github-actions github-actions bot added Content:JS JavaScript docs Content:Other Any docs not covered by another "Content:" label Content:MathML MathML docs labels Jul 24, 2023
hamishwillee
hamishwillee approved these changes Jul 24, 2023
View reviewed changes
Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent thanks.

It's a pity that we don't have a formatter for errors. A lot of these would benefit from highlighting the error name and so on.

@hamishwillee hamishwillee merged commit 6d60617 into main Jul 24, 2023
6 checks passed
@hamishwillee hamishwillee deleted the code-language/3 branch July 24, 2023 23:45
@github-actions
Copy link
Contributor

Preview URLs (100 pages)

@queengooborg queengooborg mentioned this pull request Jul 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamishwillee hamishwillee hamishwillee approved these changes

@fred-wang fred-wang Awaiting requested review from fred-wang fred-wang is a code owner automatically assigned from mdn/content-mathml

@Josh-Cena Josh-Cena Awaiting requested review from Josh-Cena Josh-Cena is a code owner automatically assigned from mdn/yari-content-javascript

Assignees
No one assigned
Labels
Content:JS JavaScript docs Content:MathML MathML docs Content:Other Any docs not covered by another "Content:" label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@queengooborg @hamishwillee