Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set code languages for various files (part 4) #28160

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Set code languages for various files (part 4) #28160

merged 1 commit into from
Jul 24, 2023

Conversation

queengooborg
Copy link
Collaborator

This PR sets the code language for various codeblocks that don't have one set, which will help us enforce setting a language on all codeblocks. This is the fourth part.

@queengooborg queengooborg requested a review from a team July 24, 2023 23:42
@queengooborg queengooborg requested a review from a team as a code owner July 24, 2023 23:42
@queengooborg queengooborg requested review from Ryuno-Ki and Elchi3 and removed request for a team July 24, 2023 23:42
@github-actions github-actions bot added Content:Other Any docs not covered by another "Content:" label Content:SVG SVG docs Content:wasm WebAssembly docs Content:WebDriver WebDriver docs Content:Security Security docs Content:PWA Progressive Web Apps content labels Jul 24, 2023
@github-actions
Copy link
Contributor

Preview URLs (57 pages)
Flaws (44)

Note! 47 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/WebDriver
Title: WebDriver
Flaw count: 3

  • broken_links:
    • Can't resolve /en-US/docs/Web/WebDriver/Types
    • Can't resolve /en-US/docs/Web/WebDriver/WebElement
    • Can't resolve /en-US/docs/Web/WebDriver/WebWindow

URL: /en-US/docs/Web/WebDriver/Errors/StaleElementReference
Title: Stale element reference
Flaw count: 9

  • broken_links:
    • Can't resolve /en-US/docs/Web/WebDriver/WebElement
    • Can't resolve /en-US/docs/Web/WebDriver/WebElement
    • Can't resolve /en-US/docs/Web/WebDriver/WebElement
    • Can't resolve /en-US/docs/Web/WebDriver/WebElement
    • Can't resolve /en-US/docs/Web/WebDriver/WebElement
    • and 4 more flaws omitted

URL: /en-US/docs/Web/WebDriver/Errors/InvalidSessionID
Title: Invalid session ID
Flaw count: 4

  • broken_links:
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/DeleteSession
    • Can't resolve /en-US/docs/Web/WebDriver/Errors/SessionNotCreated
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/NewSession
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/DeleteSession

URL: /en-US/docs/Web/WebDriver/Errors/ScriptTimeout
Title: Script timeout
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/ExecuteScript
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/ExecuteAsyncScript

URL: /en-US/docs/Web/WebDriver/Errors/JavaScriptError
Title: JavaScript error
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/ExecuteScript
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/ExecuteAsyncScript

URL: /en-US/docs/Web/WebDriver/Errors/InsecureCertificate
Title: Insecure certificate
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/NavigateTo
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/NavigateTo

URL: /en-US/docs/Web/WebDriver/Errors/InvalidCookieDomain
Title: Invalid cookie domain
Flaw count: 6

  • broken_links:
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/AddCookie
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/AddCookie
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/DeleteCookie
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/DeleteAllCookies
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/GetAllCookies
    • and 1 more flaws omitted

URL: /en-US/docs/Web/WebDriver/Commands/GetElementTagName
Title: Get Element Tag Name
Flaw count: 6

  • broken_links:
    • Can't resolve /en-US/docs/Web/WebDriver/Command
    • Can't resolve /en-US/docs/Web/WebDriver/WebElement
    • Can't resolve /en-US/docs/Web/WebDriver/WebElement
    • Can't resolve /en-US/docs/Web/WebDriver/Errors/SessionNotCreated
    • Can't resolve /en-US/docs/Web/WebDriver/Errors/NoSuchWindow
    • and 1 more flaws omitted

URL: /en-US/docs/Web/WebDriver/Commands/GetElementProperty
Title: Get Element Property
Flaw count: 7

  • macros:
    • /en-US/docs/Web/API/Element/getProperty does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Web/WebDriver/WebElement
    • Can't resolve /en-US/docs/Web/WebDriver/WebElement
    • Can't resolve /en-US/docs/Web/WebDriver/WebElement
    • Can't resolve /en-US/docs/Web/WebDriver/Errors/SessionNotCreated
    • Can't resolve /en-US/docs/Web/WebDriver/Errors/NoSuchWindow
    • and 1 more flaws omitted

URL: /en-US/docs/Web/WebDriver/Capabilities/acceptInsecureCerts
Title: acceptInsecureCerts
Flaw count: 3

  • broken_links:
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/NavigateTo
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/NavigateTo
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/NewSession

@queengooborg queengooborg mentioned this pull request Jul 24, 2023
Merged
hamishwillee
hamishwillee approved these changes Jul 24, 2023
View reviewed changes
Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

I do prefer the use of plain rather than empty, because it indicates you've thought about the type. Applying this automatically would not be something I'd inflict on end users.

@queengooborg queengooborg merged commit 4a6dacf into main Jul 24, 2023
6 checks passed
@queengooborg queengooborg deleted the code-language/4 branch July 24, 2023 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamishwillee hamishwillee hamishwillee approved these changes

@Ryuno-Ki Ryuno-Ki Awaiting requested review from Ryuno-Ki

@Elchi3 Elchi3 Awaiting requested review from Elchi3 Elchi3 is a code owner automatically assigned from mdn/yari-content-mdn

Assignees
No one assigned
Labels
Content:Other Any docs not covered by another "Content:" label Content:PWA Progressive Web Apps content Content:Security Security docs Content:SVG SVG docs Content:wasm WebAssembly docs Content:WebDriver WebDriver docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@queengooborg @hamishwillee