Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information about whitespaces text nodes #28177

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Add information about whitespaces text nodes #28177

merged 1 commit into from
Jul 26, 2023

Conversation

Float07
Copy link
Contributor

@Float07 Float07 commented Jul 25, 2023

Description

I added some information about empty text nodes in the Node.childNodes documentation, with a reference to a documentation about the subject.

This was inspired by the notes in the previousSiblings and nextSiblings pages.

Motivation

I got myself pretty confused when trying to find out why childNodes was returning an array full of empty text nodes, and took me a while to find a reference to this very helpful docs that made things clearer for me. I think other people could use this reference in the future when faced with a similar problem.

@Float07 Float07 requested a review from a team as a code owner July 25, 2023 22:05
@Float07 Float07 requested review from sideshowbarker and removed request for a team July 25, 2023 22:05
@github-actions github-actions bot added the Content:WebAPI Web API docs label Jul 25, 2023
@Float07
Copy link
Contributor Author

Float07 commented Jul 25, 2023

I was thinking that maybe adding something similar to the Node documentation could be useful as well. What do you think about that?

@github-actions
Copy link
Contributor

Preview URLs

@sideshowbarker sideshowbarker merged commit c747b53 into mdn:main Jul 26, 2023
5 checks passed
@sideshowbarker
Copy link
Collaborator

Thiago, thanks much, and congrats on landing your first docs change here — welcome aboard 🎉

@sideshowbarker
Copy link
Collaborator

I was thinking that maybe adding something similar to the Node documentation could be useful as well. What do you think about that?

That’d be great, yes

@Float07
Copy link
Contributor Author

Float07 commented Jul 26, 2023

Alright, thanks for the feedback ;)

@Float07 Float07 deleted the patch-1 branch July 26, 2023 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants