ended double use of color to prevent misunderstanding #28208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
background is usually white in the browser fill of the circle is default black Black and white are also used in defining the mask, that's why I propose different colors for 'background' and the circle's fill
steltenpower
requested review from
a team and
Ryuno-Ki
and removed request for
a team
sideshowbarker
approved these changes
Jul 27, 2023
|
Preview URLs Flaws (1)URL:
|
|
Ruud, great to see you here; thanks much, and congrats on landing your first docs change here — welcome aboard 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
background is usually white in the browser
fill of the circle is default black
Black and white are also used in defining the mask, that's why I propose different colors for 'background' and the circle's fill
Description
Motivation
Additional details
Related issues and pull requests