Add prose and meta-docs for [LegacyNullToEmptyString] #28213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Content:WebAPI
6 tasks
wbamberg
reviewed
Jul 27, 2023
...ting_guidelines/howto/write_an_api_reference/information_contained_in_a_webidl_file/index.md
Outdated
Show resolved
Hide resolved
wbamberg
reviewed
Jul 27, 2023
files/en-us/web/api/canvasrenderingcontext2d/createpattern/index.md
Outdated
Show resolved
Hide resolved
Rumyra
previously requested changes
Aug 2, 2023
...ting_guidelines/howto/write_an_api_reference/information_contained_in_a_webidl_file/index.md
Outdated
Show resolved
Hide resolved
|
All looks good to me! Agree with @wbamberg suggestions and one nit :) |
|
@teoli2003 , are you coming back to this, or should we close it for now? |
|
Hi @teoli2003 shall we close this for now? |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
teoli2003
commented
Jan 10, 2024
...ting_guidelines/howto/write_an_api_reference/information_contained_in_a_webidl_file/index.md
Outdated
Show resolved
Hide resolved
…e/information_contained_in_a_webidl_file/index.md Co-authored-by: Ruth John <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…e/information_contained_in_a_webidl_file/index.md
teoli2003
force-pushed
the
LegacyNullToEmptyString
branch
from
20f91aa
to
33a322b
Compare
I have fixed all open points and rebased. Let's ask for a re-review. |
teoli2003
removed
the
awaiting response
Josh-Cena
reviewed
Jan 13, 2024
...ting_guidelines/howto/write_an_api_reference/information_contained_in_a_webidl_file/index.md
Outdated
Show resolved
Hide resolved
|
This pull request has merge conflicts that must be resolved before it can be merged. |
Co-authored-by: Joshua Chen <[email protected]>
Co-authored-by: Joshua Chen <[email protected]>
Josh-Cena
approved these changes
Jul 10, 2024
|
I'm open to merging this if no other feedback is given before end of week. |
Josh-Cena
reviewed
Jul 12, 2024
...-us/mdn/writing_guidelines/page_structures/page_types/api_property_subpage_template/index.md
Outdated
Show resolved
Hide resolved
|
Going to merge now. Thanks everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds relevant information to existing MDN pages about properties or method parameters prefixed with the WebIDL
[LegacyNullToEmptyString].Motivation
This is part of openwebdocs/project#159 where we want to uniformize and add more information stored in WebIDLs files. Standardizing them makes them easier to understand and MDN Web docs articles more precise.
Additional details
What does this extended attribute mean?
This extended attribute alters how
nullvalues are converted to a string. The standard way is to convertnullto the string"null". When this extended attribute is present, thenullobject is converted to an empty string ("").What does this PR do?
nullvalue, with a tiny inline example.nullis passed.Related issues and pull requests
None.