remove extra "

[yin1999]

Description

remove extra "

[github-actions]

Preview URLs

• /en-US/docs/Learn/Forms/How_to_build_custom_form_controls

(comment last updated: 2023-07-27 15:42:53)

[CBID2]

Looks pretty good @yin1999! :)

[hamishwillee]

Thanks for the fix. Running prettier on HTML is usually not a good idea - it does a horrible job. Was this something you chose to do or the toolchain forced you to do?

Added it accidentally. The fix itself is good but the HTML prettier stuff is not.

[yin1999]

Thanks for the fix. Running prettier on HTML is usually not a good idea - it does a horrible job. Was this something you chose to do or the toolchain forced you to do?

We still run prettier format check in translated-content. After I fix the broken html (in mdn/translated-content#14568), the format check just failed. So I run yarn prettier -w /path/to/file to those two PRs.

[hamishwillee]

OK. Thanks. @queengooborg Thoughts on this? @yin1999 is "doing the right thing", but the resulting prettier changes to HTML are rubbish.

[queengooborg]

Prettier's formatting for HTML is not great, I think we all agree on this. We don't have any control over it, though. Plus, we already format all our HTML with Prettier.

[hamishwillee]

Really? I thought we formatted only the JS. I hate this. I would have suggested nolint.

[hamishwillee]

Hi @yin1999

Just FYI, following some advice from @queengooborg I improved the HTML in #28230 . What I hadn't realized is that prettier does different things based on your starting point. So by putting some of the text on different lines it did a better job of formatting.

Thanks for your fix!

[yin1999]

Hi @yin1999

Just FYI, following some advice from @queengooborg I improved the HTML in #28230 . What I hadn't realized is that prettier does different things based on your starting point. So by putting some of the text on different lines it did a better job of formatting.

Thanks for your fix!

Thanks for the additional work on this @hamishwillee 👍