Update examples in “URL: port” doc #28238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lthough specified
|
leaving here the change for your convinience Port 80 + 443 in combination with http + https show empty port new URL("https://example.com:443/svn/Repos/").port; // shows ''new URL("http://example.com:80/svn/Repos/").port; // shows '' |
|
Preview URLs (comment last updated: 2023-07-28 09:32:38) |
sideshowbarker
approved these changes
Jul 28, 2023
sideshowbarker
changed the title
|
1.) There is a small typo in : nubmer ... should read: number. In update from @sideshowbarker 2.) new URL('sftp://foo.bar:21/').port also returns empty string. |
If you’d be willing to put together a follow-up PR with those changes, I could review it and merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allthough specified, the port property returns empty string on https + 443 port, http + 80 port.
Description
Adding two examples where port property returns empty string, allthough it was specified in the construct.
Motivation
Adding the examples, as it is unclear to me, if this is working as designed or a feature. Anyhow it might lead hard to discover bugs, if we rely on the port property being filled properly.
I hope that the examples will help developers to prevent bugs.
Additional details
Related issues and pull requests