Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to frame-ancestors #28246

Merged
merged 10 commits into from
Jul 31, 2023
Merged

Add link to frame-ancestors #28246

merged 10 commits into from
Jul 31, 2023

Conversation

rohini-ranjanR
Copy link
Contributor

Description

using CSP and frame-ancestors URL in See also section

Motivation

Additional details

Related issues and pull requests

Fixes #27754

@rohini-ranjanR rohini-ranjanR requested a review from a team as a code owner July 28, 2023 14:13
@rohini-ranjanR rohini-ranjanR requested review from chrisdavidmills and removed request for a team July 28, 2023 14:13
@github-actions github-actions bot added the Content:HTML Hypertext Markup Language docs label Jul 28, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 28, 2023

Preview URLs

(comment last updated: 2023-07-31 00:35:16)

@@ -153,6 +153,12 @@ This element's attributes include the [global attributes](/en-US/docs/Web/HTML/G
</td>
<td>The metadata has been loaded.</td>
</tr>
<tr>
<td>
{{domxref("HTMLMediaElement.loadstart_event", 'loadstart')}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a separate PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mistakenly commit it here. Here's the PR for this issue #28242

files/en-us/web/html/element/frame/index.md Outdated Show resolved Hide resolved
CSP frame-ancestors url added in see also section
@github-actions github-actions bot added the merge conflicts 🚧 [PR only] label Jul 29, 2023
@github-actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@@ -234,4 +234,4 @@ Without this title, they have to navigate into the `<iframe>` to determine what

## See also

- [Privacy, permissions, and information security](/en-US/docs/Web/Privacy)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, why is this removed? We are adding links, not changing them.

@github-actions github-actions bot removed the merge conflicts 🚧 [PR only] label Jul 31, 2023
@Josh-Cena Josh-Cena changed the title url: using correct url Add link to frame-ancestors Jul 31, 2023
@Josh-Cena Josh-Cena merged commit 2b649ca into mdn:main Jul 31, 2023
7 checks passed
@rohini-ranjanR rohini-ranjanR deleted the url_change branch July 31, 2023 01:00
@chrisdavidmills chrisdavidmills removed their request for review July 31, 2023 08:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content:HTML Hypertext Markup Language docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No mention of CSPs frame-ancestors.
2 participants