Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve grammar of subgrid document #28248

Merged
merged 2 commits into from
Aug 1, 2023
Merged

improve grammar of subgrid document #28248

merged 2 commits into from
Aug 1, 2023

Conversation

gianpaj
Copy link
Contributor

@gianpaj gianpaj commented Jul 28, 2023

Description

improve grammar of subgrid document

Motivation

make it easier to read

@gianpaj gianpaj requested a review from a team as a code owner July 28, 2023 15:04
@gianpaj gianpaj requested review from chrisdavidmills and removed request for a team July 28, 2023 15:04
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Jul 28, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 28, 2023 •
edited
Loading

Preview URLs

(comment last updated: 2023-08-01 04:43:15)

wbamberg
wbamberg reviewed Jul 28, 2023
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @gianpaj ! These are overall good changes but I argued with one of them :).

@chrisdavidmills chrisdavidmills removed their request for review July 31, 2023 08:11
wbamberg
wbamberg approved these changes Aug 1, 2023
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you @gianpaj !

@wbamberg wbamberg merged commit 01a2d3d into mdn:main Aug 1, 2023
7 checks passed
@gianpaj gianpaj deleted the patch-1 branch August 2, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbamberg wbamberg wbamberg approved these changes

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gianpaj @wbamberg