Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Re-enable Prettier check on pull requests #28254

Closed
wants to merge 1 commit into from

Conversation

queengooborg
Copy link
Collaborator

Now that #28228 has landed, which introduces a review bot for Prettier formatting, I think we're ready to re-enable Prettier formatting checks. This PR does just that.

@queengooborg queengooborg requested a review from a team as a code owner July 29, 2023 06:58
@github-actions github-actions bot added the system [PR only] Infrastructure and configuration for the project label Jul 29, 2023
@OnkarRuikar
Copy link
Contributor

The Prettier is being run already in reviewdog.yml. Why do we want to run Prettier twice? Why do we want to report the issues twice?

@yin1999
Copy link
Member

yin1999 commented Jul 31, 2023

The Prettier is being run already in reviewdog.yml. Why do we want to run Prettier twice? Why do we want to report the issues twice?

I chatted with @queengooborg about the following idea yesterday:

Maybe we could merge this with reviewdog into one workflow, as GitHub support failure with conditions. So we could only run reviewdog to post seggestions when the style check is failed. And the failed ci could still let the maintainer know there is something need to be done before merging the PR.

@OnkarRuikar
Copy link
Contributor

I chatted with @queengooborg about the following idea yesterday:

Maybe we could merge this with reviewdog into one workflow, as GitHub support failure with conditions. So we could only run reviewdog to post seggestions when the style check is failed. And the failed ci could still let the maintainer know there is something need to be done before merging the PR.

We don't have to do the linting twice even in same wokflow. 🤓
Why not straight up do the --fix step? It gives us fixes as well as failure logs. Could you look at my PR that includes all the linters with reviewdog: #28240

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2023

This pull request has merge conflicts that must be resolved before it can be merged.

@queengooborg
Copy link
Collaborator Author

Closing as it has been superseded.

@queengooborg queengooborg deleted the prettier-ci-enable branch August 6, 2023 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge conflicts 🚧 [PR only] system [PR only] Infrastructure and configuration for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants