Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test reviewdog for Prettier #28295

Closed
wants to merge 1 commit into from
Closed

Conversation

OnkarRuikar
Copy link
Contributor

@OnkarRuikar OnkarRuikar commented Jul 31, 2023

@github-actions github-actions bot added the Content:Games Games docs label Jul 31, 2023
@github-actions
Copy link
Contributor

Preview URLs

External URLs (1)

URL: /en-US/docs/Games
Title: Game development

@OnkarRuikar
Copy link
Contributor Author

OnkarRuikar commented Jul 31, 2023

@bsmth, @queengooborg we do need a separate token with PR write permissions for this to work:

reviewdog: This GitHub token doesn't have write permission of Review API [1], 
so reviewdog will report results via logging command [2] and create annotations similar to
github-pr-check reporter as a fallback.
[1]: https://docs.github.com/en/actions/reference/events-that-trigger-workflows#pull_request_target, 
[2]: https://help.github.com/en/actions/automating-your-workflow-with-github-actions/development-tools-for-github-actions#logging-commands
Warning: [prettier] reported by reviewdog 🐶


Raw Output:
files/en-us/games/index.md:11:-## Develop web games  
files/en-us/games/index.md:11:+## Develop web games
Warning: [prettier] reported by reviewdog 🐶


Raw Output:
files/en-us/games/index.md:18:-div { background-color: green; }
files/en-us/games/index.md:18:+div {
files/en-us/games/index.md:19:+  background-color: green;
files/en-us/games/index.md:20:+}
Warning: [prettier] reported by reviewdog 🐶


Raw Output:
files/en-us/games/index.md:20:-  content: 'content after span';
files/en-us/games/index.md:22:+  content: "content after span";
Warning: [prettier] reported by reviewdog 🐶


Raw Output:
files/en-us/games/index.md:38:-For a list of *web game* examples, see our [tutorials page](/en-US/docs/Games/Tutorials). Also, check out [games.mozilla.org](https://games.mozilla.org/) for more useful resources!
files/en-us/games/index.md:40:+For a list of _web game_ examples, see our [tutorials page](/en-US/docs/Games/Tutorials). Also, check out [games.mozilla.org](https://games.mozilla.org/) for more useful resources!
Dropped refs/stash@{0} (cc03b5bf80a968c17b7af08d7c8f6ed53d343c90)

@bsmth
Copy link
Member

bsmth commented Aug 15, 2023

Thanks @OnkarRuikar - closing this one out as I think we're done testing :)

@bsmth bsmth closed this Aug 15, 2023
@OnkarRuikar OnkarRuikar deleted the test_reviewdog branch August 15, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Games Games docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants