Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 27197: Remove window's copy of DOMContentLoaded; redirect to document's copy #28315

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

wbamberg
Copy link
Collaborator

@wbamberg wbamberg commented Aug 1, 2023

Fixes #27197. Also fixes #19269.

This PR:

  • deletes Window's version of DOMContentLoaded
  • folds the info from Adding missing detail to DOMContentLoaded #19924 into Document's version
  • redirects Window's version to Document's
  • updated all the places Yari complained about links to Window's version

I think this is what we want here?

I also deleted the para about synchronous JS, as this seemed very out of date and AFAICT is solved these days by defer.

@wbamberg wbamberg requested review from a team as code owners August 1, 2023 04:23
@wbamberg wbamberg requested review from rebloor and sideshowbarker and removed request for a team August 1, 2023 04:23
@github-actions github-actions bot added Content:WebExt WebExtensions docs Content:WebAPI Web API docs Content:Learn Learning area docs Content:Performance Web performance docs Content:Events Events docs labels Aug 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

Preview URLs (11 pages)
Flaws (37)

Note! 5 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/Events
Title: Event reference
Flaw count: 6

  • broken_links:
    • Can't resolve /en-US/docs/Web/API/SVGElement/abort_event
    • Can't resolve /en-US/docs/Web/API/SVGElement/resize_event
    • Can't resolve /en-US/docs/Web/API/SVGElement/scroll_event
    • Can't resolve /en-US/docs/Web/API/SVGElement/unload_event
    • Can't resolve /en-US/docs/Web/API/Window.devicemotion_event
    • and 1 more flaws omitted

URL: /en-US/docs/Web/API/HTMLScriptElement
Title: HTMLScriptElement
Flaw count: 13

  • macros:
    • /en-US/docs/Web/API/Element/error_event redirects to /en-US/docs/Web/API/HTMLElement/error_event
    • /en-US/docs/Web/API/HTMLScriptElement/type does not exist
    • /en-US/docs/Web/API/HTMLScriptElement/src does not exist
    • /en-US/docs/Web/API/HTMLScriptElement/event does not exist
    • /en-US/docs/Web/API/HTMLScriptElement/charset does not exist
    • and 8 more flaws omitted

URL: /en-US/docs/Web/API/Document/DOMContentLoaded_event
Title: Document: DOMContentLoaded event
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/Window/DOMContentLoaded_event redirects to /en-US/docs/Web/API/Document/DOMContentLoaded_event

URL: /en-US/docs/Web/API/Window
Title: Window
Flaw count: 12

  • macros:
    • /en-US/docs/Web/API/Window/setResizable does not exist
    • /en-US/docs/Web/API/Window/animationcancel_event redirects to /en-US/docs/Web/API/Element/animationcancel_event
    • /en-US/docs/Web/API/Window/animationend_event redirects to /en-US/docs/Web/API/Element/animationend_event
    • /en-US/docs/Web/API/Window/animationiteration_event redirects to /en-US/docs/Web/API/Element/animationiteration_event
    • /en-US/docs/Web/API/Window/animationstart_event redirects to /en-US/docs/Web/API/Element/animationstart_event
    • and 7 more flaws omitted

URL: /en-US/docs/Web/Performance
Title: Web performance
Flaw count: 4

  • broken_links:
    • Can't resolve /en-US/docs/Learn/Performance/Mobile
    • Can't resolve /en-US/docs/Web/API/Performance_API/Using_the_Performance_API
    • Can't resolve /en-US/docs/Web/API/Performance_Timeline/Using_Performance_Timeline
    • Can't resolve /en-US/docs/Web/API/Performance_Timeline

URL: /en-US/docs/Web/Performance/Navigation_and_resource_timings
Title: Navigation and resource timings
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/API/Window/DOMContentLoaded_event

@wbamberg wbamberg changed the title Remove window's copy of DOMContentLoaded; redirect to document's copy Fix issue 27197: Remove window's copy of DOMContentLoaded; redirect to document's copy Aug 1, 2023
Copy link
Contributor

@rebloor rebloor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In context of the other changes, the changes to the web extension pages look OK.

@sideshowbarker sideshowbarker merged commit 9c74ee8 into mdn:main Aug 3, 2023
7 checks passed
@hamishwillee hamishwillee mentioned this pull request Aug 3, 2023
yin1999 added a commit to mdn/translated-content that referenced this pull request Aug 4, 2023
yin1999 added a commit to mdn/translated-content that referenced this pull request Aug 4, 2023
* zh-cn: sync translated content

* remove links to window DOMContentLoaded event

ref: mdn/content#28315

* ignore wikihistory

---------

Co-authored-by: Allo <[email protected]>
yin1999 added a commit to mdn/translated-content that referenced this pull request Aug 4, 2023
yin1999 added a commit to mdn/translated-content that referenced this pull request Aug 4, 2023
* zh-tw: sync translated content

* remove links to window DOMContentLoaded event

ref: mdn/content#28315

---------

Co-authored-by: Allo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Events Events docs Content:Learn Learning area docs Content:Performance Web performance docs Content:WebAPI Web API docs Content:WebExt WebExtensions docs
Projects
None yet
3 participants