Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pr-check-lint): skip setting up reviewdog if not needed #28420

Merged
merged 1 commit into from
Aug 6, 2023

Conversation

yin1999
Copy link
Member

@yin1999 yin1999 commented Aug 6, 2023

Description

skip 'setup reviewdog' if not needed

@yin1999 yin1999 requested a review from a team as a code owner August 6, 2023 09:09
@github-actions github-actions bot added the system [PR only] Infrastructure and configuration for the project label Aug 6, 2023
@yin1999 yin1999 changed the title chore(pr-check-lint): skip 'setup reviewdog' if not needed chore(pr-check-lint): skip setting up reviewdog if not needed Aug 6, 2023
queengooborg
queengooborg previously approved these changes Aug 6, 2023
@queengooborg queengooborg dismissed their stale review August 6, 2023 10:47

Wait, something caught my eye...

Copy link
Collaborator

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something caught my eye before, but looking closer, it seems all good now -- LGTM!

@queengooborg queengooborg merged commit e6c1bb5 into mdn:main Aug 6, 2023
5 of 6 checks passed
@yin1999 yin1999 deleted the yin1999-patch-1-2 branch August 6, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
system [PR only] Infrastructure and configuration for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants