Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pr-check_redirect): correct the path filter #30210

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Conversation

yin1999
Copy link
Member

@yin1999 yin1999 commented Nov 12, 2023

Description

correct the path filter

@yin1999 yin1999 requested a review from a team as a code owner November 12, 2023 03:22
@github-actions github-actions bot added the system [PR only] Infrastructure and configuration for the project label Nov 12, 2023
Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OnkarRuikar This looks right to me, given the new file exists and the old one does not. But since you touched the file perhaps you could confirm. Approving but not merging.

@OnkarRuikar
Copy link
Contributor

@OnkarRuikar This looks right to me, given the new file exists and the old one does not. But since you touched the file perhaps you could confirm. Approving but not merging.

Looks good to me. The workflow "Check Redirects / check-redirects" has run for the commit so the change works.

@hamishwillee
Copy link
Collaborator

There is one check fail - do we need to worry about that?

@yin1999
Copy link
Member Author

yin1999 commented Nov 13, 2023

There is one check fail - do we need to worry about that?

The "System file changes" workflow would always fail. This is used to note us that the current PR has modified files related to the infrastructure of the current repo.

@OnkarRuikar
Copy link
Contributor

There is one check fail - do we need to worry about that?

No need to worry about "System file changes / block" check. It's a deliberate failure (exit 1) to avoid accidental or auto merges on system file changes.

@hamishwillee hamishwillee merged commit 8dac660 into mdn:main Nov 13, 2023
6 of 7 checks passed
@hamishwillee
Copy link
Collaborator

Thanks! I'm brave enough to merge then :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
system [PR only] Infrastructure and configuration for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants