Bump prettier from 3.0.3 to 3.1.0 #30241

dependabot · 2023-11-13T15:02:58Z

Bumps prettier from 3.0.3 to 3.1.0.

Release notes

Sourced from prettier's releases.

3.1.0

diff

🔗 Release note

Changelog

Sourced from prettier's changelog.

3.1.0

diff

🔗 Release Notes

Commits

e8ac9f8 Release 3.1.0
6a1d409 chore(deps): update dependency eslint-plugin-regexp to v2 (#15521)
f4d93d3 chore(deps): update dependency esbuild to v0.19.5 (#15630)
4fc71a5 chore(deps): update dependency flow-parser to v0.221.0 (#15637)
d452f45 chore(deps): update dependency eslint-plugin-jest to v27.6.0 (#15635)
eb84a60 chore(deps): update dependency @types/estree to v1.0.5 (#15625)
2af23ee chore(deps): update dependency webpack to v5.89.0 (#15640)
8f27c73 chore(deps): update dependency eslint-plugin-unicorn to v49 (#15642)
cdc5f5a chore(deps): update dependency webpack to v5.89.0 (#15639)
14607ef chore(deps): update dependency eslint-plugin-n to v16.3.1 (#15636)
Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @mdn-bot.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

mdn-bot

@dependabot squash and merge

dependabot · 2023-11-13T15:08:39Z

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

mdn-bot

@dependabot squash and merge

Bumps [prettier](https://github.com/prettier/prettier) from 3.0.3 to 3.1.0. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](prettier/prettier@3.0.3...3.1.0) --- updated-dependencies: - dependency-name: prettier dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

mdn-bot

@dependabot squash and merge

bsmth · 2023-11-13T16:32:38Z

I believe these are the changes that must land in content first for this:

https://prettier.io/blog/2023/11/13/3.1.0.html#improve-formatting-for-assignment-its-left-can-break-15547httpsgithubcomprettierprettierpull15547-by-sosukesuzukihttpsgithubcomsosukesuzuki

bsmth · 2023-11-13T16:56:26Z

See #30243

teoli2003

Technical "request changes" so that it doesn't get merged automatically

files/en-us/learn/javascript/asynchronous/introducing_workers/index.md

...s/en-us/learn/tools_and_testing/client-side_javascript_frameworks/svelte_typescript/index.md

...us/learn/tools_and_testing/client-side_javascript_frameworks/svelte_variables_props/index.md

files/en-us/web/api/webgl_api/by_example/hello_vertex_attributes/index.md

files/en-us/web/api/webgl_api/by_example/textures_from_code/index.md

files/en-us/web/javascript/reference/operators/import/index.md

github-actions · 2023-11-14T05:23:33Z

files/en-us/web/javascript/reference/operators/instanceof/index.md

@@ -215,7 +215,7 @@ if (!(mycar instanceof Car)) {
 This is really different from:

 ```js example-bad
-if (!mycar instanceof Car) {
+if ((!mycar) instanceof Car) {


[mdn-linter] _{reported by reviewdog 🐶}

Suggested change

if ((!mycar) instanceof Car) {

if (!mycar instanceof Car) {

Accepted this one, added a no-lint in a subsequent commit.

files/en-us/web/javascript/reference/template_literals/index.md

github-actions · 2023-11-14T05:27:38Z

Preview URLs (22 pages)

Flaws (16)

Note! 21 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/HTMLMarqueeElement
Title: HTMLMarqueeElement
Flaw count: 16

macros:
- /en-US/docs/Web/API/HTMLMarqueeElement/behavior does not exist
- /en-US/docs/Web/API/HTMLMarqueeElement/bgColor does not exist
- /en-US/docs/Web/API/HTMLMarqueeElement/direction does not exist
- /en-US/docs/Web/API/HTMLMarqueeElement/height does not exist
- /en-US/docs/Web/API/HTMLMarqueeElement/hspace does not exist
- and 11 more flaws omitted

(comment last updated: 2023-11-14 05:48:21)

…x.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

teoli2003 · 2023-11-14T05:58:38Z

@bsmth I've merged both PR into one: that way, when we land this one, everything should be fixed. (I used gh pr checkout 30241 to get this branch locally)

I paid attention to keeping the "nolint" on the particular case for instanceof that Josh and you noticed.

I wonder if "lint and review content files" fails because the linter runs with the Prettier from Yari (and it may be 3.0.0!) instead of the new version.

I'm away this morning, so I'm a bit afraid of landing this now as I think it may lead to lint errors elsewhere, and I won't be there to do a revert.

My 'Request for change' is purely technical (to be sure the MDN bot will not merge this on its own), so if you want to go ahead, feel free to override it; I wouldn't mind.

bsmth · 2023-11-14T09:26:20Z

I wonder if "lint and review content files" fails because the linter runs with the Prettier from Yari (and it may be 3.0.0!) instead of the new version.

Is that what's happening? That would be surprising.

Prettier counterpart in Yari is mdn/yari#10016 although it would be great to check if this is the case with the Prettier version. I will take a look today 👀

OnkarRuikar · 2023-11-14T12:59:04Z

@teoli2003 and @bsmth for security reasons in linting workflow we run scripts from main branch and not from PR branch. So the prettier version from main branch is being used for linting.

The best way in such case is to push locally linted code to PR branch and force merge the PR.

teoli2003 · 2023-11-14T13:05:04Z

So, it looks like all will be "normal" once we push this.

bsmth · 2023-11-14T13:49:09Z

@teoli2003 and @bsmth for security reasons in linting workflow we run scripts from main branch and not from PR branch. So the prettier version from main branch is being used for linting.

Gotcha, tnx. It might be nice to have this documented in https://github.com/mdn/content/tree/main/.github/workflows for future (adding a README.md in this dir, possibly).

Josh-Cena · 2023-11-18T21:30:43Z

@teoli2003 Heads up that you checked in an entire package-lock.json. You probably want to remove that?

dependabot bot requested a review from mdn-bot as a code owner November 13, 2023 15:02

dependabot bot added dependencies [PR only] Pull requests that update a dependency file javascript [PR only] Pull requests that update Javascript code labels Nov 13, 2023

github-actions bot added the system [PR only] Infrastructure and configuration for the project label Nov 13, 2023

mdn-bot approved these changes Nov 13, 2023

View reviewed changes

dependabot bot force-pushed the dependabot/npm_and_yarn/prettier-3.1.0 branch from c5d6b3f to fbc836e Compare November 13, 2023 15:09

mdn-bot approved these changes Nov 13, 2023

View reviewed changes

dependabot bot force-pushed the dependabot/npm_and_yarn/prettier-3.1.0 branch from fbc836e to 548586f Compare November 13, 2023 15:12

mdn-bot approved these changes Nov 13, 2023

View reviewed changes

bsmth self-assigned this Nov 13, 2023

Run prettier locally that should fix all the errors

a31e3ea

teoli2003 requested review from a team as code owners November 14, 2023 05:22

teoli2003 requested review from sideshowbarker and estelle and removed request for a team November 14, 2023 05:22

teoli2003 suggested changes Nov 14, 2023

View reviewed changes

github-actions bot reviewed Nov 14, 2023

View reviewed changes

teoli2003 and others added 3 commits November 14, 2023 06:34

Update files/en-us/web/javascript/reference/operators/instanceof/inde…

36a3435

…x.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Add nolint to example-bad of JS instaceof docs

554e0c5

Revert changes in package.json yarn.lock erroneously done locally

d794327

github-actions bot removed the system [PR only] Infrastructure and configuration for the project label Nov 14, 2023

Reapply package and yarn changes

573c905

github-actions bot added the system [PR only] Infrastructure and configuration for the project label Nov 14, 2023

teoli2003 self-requested a review November 14, 2023 13:05

teoli2003 approved these changes Nov 14, 2023

View reviewed changes

teoli2003 merged commit cbfc561 into main Nov 14, 2023
16 of 17 checks passed

teoli2003 deleted the dependabot/npm_and_yarn/prettier-3.1.0 branch November 14, 2023 13:08

OnkarRuikar mentioned this pull request Nov 14, 2023

fix: format docs with prettier 3.1 #30270

Closed

yin1999 mentioned this pull request Nov 16, 2023

build(deps): bump prettier from 3.0.3 to 3.1.0 mdn/translated-content#16939

Merged

teoli2003 mentioned this pull request Nov 18, 2023

Delete package-lock.json #30371

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump prettier from 3.0.3 to 3.1.0 #30241

Bump prettier from 3.0.3 to 3.1.0 #30241

dependabot bot commented on behalf of github Nov 13, 2023 •

edited

Loading

mdn-bot left a comment

dependabot bot commented on behalf of github Nov 13, 2023

mdn-bot left a comment

mdn-bot left a comment

bsmth commented Nov 13, 2023

bsmth commented Nov 13, 2023

teoli2003 left a comment

github-actions bot Nov 14, 2023

teoli2003 Nov 14, 2023

github-actions bot commented Nov 14, 2023 •

edited

Loading

teoli2003 commented Nov 14, 2023

bsmth commented Nov 14, 2023

OnkarRuikar commented Nov 14, 2023

teoli2003 commented Nov 14, 2023

bsmth commented Nov 14, 2023 •

edited

Loading

Josh-Cena commented Nov 18, 2023

Bump prettier from 3.0.3 to 3.1.0 #30241

Bump prettier from 3.0.3 to 3.1.0 #30241

Conversation

dependabot bot commented on behalf of github Nov 13, 2023 • edited Loading

3.1.0

3.1.0

mdn-bot left a comment

Choose a reason for hiding this comment

dependabot bot commented on behalf of github Nov 13, 2023

mdn-bot left a comment

Choose a reason for hiding this comment

mdn-bot left a comment

Choose a reason for hiding this comment

bsmth commented Nov 13, 2023

bsmth commented Nov 13, 2023

teoli2003 left a comment

Choose a reason for hiding this comment

github-actions bot Nov 14, 2023

Choose a reason for hiding this comment

teoli2003 Nov 14, 2023

Choose a reason for hiding this comment

github-actions bot commented Nov 14, 2023 • edited Loading

teoli2003 commented Nov 14, 2023

bsmth commented Nov 14, 2023

OnkarRuikar commented Nov 14, 2023

teoli2003 commented Nov 14, 2023

bsmth commented Nov 14, 2023 • edited Loading

Josh-Cena commented Nov 18, 2023

dependabot bot commented on behalf of github Nov 13, 2023 •

edited

Loading

github-actions bot commented Nov 14, 2023 •

edited

Loading

bsmth commented Nov 14, 2023 •

edited

Loading