Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

29786 ship light dark #30244

Merged
merged 40 commits into from
Nov 17, 2023
Merged

29786 ship light dark #30244

merged 40 commits into from
Nov 17, 2023

Conversation

dletorey
Copy link
Contributor

Description

Have documented the light-dark() CSS color function and created links and references on the appropriate pages

Motivation

Working on Issue 29786 for the release of light-dark() CSS color function in Firefox 120

Additional details

Bugzilla 1856999

Related issues and pull requests

@dletorey dletorey requested review from a team as code owners November 13, 2023 17:02
@dletorey dletorey requested review from estelle and zfox23 and removed request for a team November 13, 2023 17:02
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:Firefox Content in the Mozilla/Firefox subtree labels Nov 13, 2023
Copy link
Contributor

github-actions bot commented Nov 13, 2023

Preview URLs (6 pages)
External URLs (1)

URL: /en-US/docs/Mozilla/Firefox/Releases/120
Title: Firefox 120 for developers

(comment last updated: 2023-11-17 09:38:39)

Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the content is excellent. I am being pedantic while hopefully making it even clearer.

files/en-us/web/css/color_value/light-dark/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/color_value/light-dark/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/color_value/light-dark/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/color_value/light-dark/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/color_value/light-dark/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/color_value/light-dark/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/color_value/light-dark/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_functions/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/color_value/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/color-scheme/index.md Outdated Show resolved Hide resolved
teoli2003 pushed a commit to mdn/data that referenced this pull request Nov 14, 2023
### Description

Added the `light-dark()` CSS color function syntax

### Motivation

Working on [Issue 29786](mdn/content#29786)
for the release of `light-dark()` CSS color function in Firefox 120

### Additional details

[Bugzilla 1856999](https://bugzilla.mozilla.org/show_bug.cgi?id=1856999)

### Related issues and pull requests

- [Content Pull Request](mdn/content#30244)
- [BCD Pull
Request](mdn/browser-compat-data#21226)
@dletorey dletorey mentioned this pull request Nov 14, 2023
10 tasks
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more comments, then i think we're good to go.

files/en-us/web/css/color_value/light-dark/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/color_value/light-dark/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/color_value/light-dark/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/color_value/light-dark/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/color_value/light-dark/index.md Outdated Show resolved Hide resolved
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. just one edit

files/en-us/web/css/color_value/light-dark/index.md Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the merge conflicts 🚧 [PR only] label Nov 17, 2023
@dletorey dletorey merged commit 2e2c81f into mdn:main Nov 17, 2023
7 checks passed
@dletorey dletorey deleted the 29786-ship-light-dark branch November 29, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs Content:Firefox Content in the Mozilla/Firefox subtree
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants