-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
29786 ship light dark #30244
29786 ship light dark #30244
Conversation
Preview URLs (6 pages)External URLs (1)URL:
(comment last updated: 2023-11-17 09:38:39) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the content is excellent. I am being pedantic while hopefully making it even clearer.
### Description Added the `light-dark()` CSS color function syntax ### Motivation Working on [Issue 29786](mdn/content#29786) for the release of `light-dark()` CSS color function in Firefox 120 ### Additional details [Bugzilla 1856999](https://bugzilla.mozilla.org/show_bug.cgi?id=1856999) ### Related issues and pull requests - [Content Pull Request](mdn/content#30244) - [BCD Pull Request](mdn/browser-compat-data#21226)
Co-authored-by: Estelle Weyl <[email protected]>
Co-authored-by: Estelle Weyl <[email protected]>
Co-authored-by: Estelle Weyl <[email protected]>
Co-authored-by: Estelle Weyl <[email protected]>
Co-authored-by: Estelle Weyl <[email protected]>
Co-authored-by: Estelle Weyl <[email protected]>
Co-authored-by: Estelle Weyl <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…tent into 29786-ship-light-dark
Co-authored-by: Estelle Weyl <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more comments, then i think we're good to go.
Co-authored-by: Estelle Weyl <[email protected]>
Co-authored-by: Estelle Weyl <[email protected]>
Co-authored-by: Estelle Weyl <[email protected]>
Co-authored-by: Estelle Weyl <[email protected]>
Co-authored-by: Estelle Weyl <[email protected]>
… would be the darker and vice versa
This pull request has merge conflicts that must be resolved before it can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. just one edit
Co-authored-by: Estelle Weyl <[email protected]>
Description
Have documented the
light-dark()
CSS color function and created links and references on the appropriate pagesMotivation
Working on Issue 29786 for the release of
light-dark()
CSS color function in Firefox 120Additional details
Bugzilla 1856999
Related issues and pull requests