Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port global var description to let #30388

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Port global var description to let #30388

merged 2 commits into from
Nov 20, 2023

Conversation

Josh-Cena
Copy link
Member

Description

Port #28068 to let. This came out of microsoft/TypeScript#56442

Motivation

Additional details

Related issues and pull requests

@Josh-Cena Josh-Cena requested a review from a team as a code owner November 20, 2023 02:24
@Josh-Cena Josh-Cena requested review from teoli2003 and removed request for a team November 20, 2023 02:24
@github-actions github-actions bot added the Content:JS JavaScript docs label Nov 20, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 20, 2023 •
edited
Loading

Preview URLs

(comment last updated: 2023-11-20 03:18:25)

hamishwillee
hamishwillee approved these changes Nov 20, 2023
View reviewed changes
Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this enhancement.

@Josh-Cena Josh-Cena merged commit 66149c2 into mdn:main Nov 20, 2023
7 checks passed
@Josh-Cena Josh-Cena deleted the fix-let branch November 23, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamishwillee hamishwillee hamishwillee approved these changes

@teoli2003 teoli2003 Awaiting requested review from teoli2003 teoli2003 is a code owner automatically assigned from mdn/yari-content-javascript

Assignees
No one assigned
Labels
Content:JS JavaScript docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Josh-Cena @hamishwillee