-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Editorial review for Shared Storage API docs #30427
feat: Editorial review for Shared Storage API docs #30427
Conversation
Co-authored-by: sideshowbarker <[email protected]>
Co-authored-by: sideshowbarker <[email protected]>
Co-authored-by: sideshowbarker <[email protected]>
Co-authored-by: sideshowbarker <[email protected]>
…nt into shared-storage-api
Co-authored-by: Dipika Bhattacharya <[email protected]>
Co-authored-by: Dipika Bhattacharya <[email protected]>
Co-authored-by: Dipika Bhattacharya <[email protected]>
Co-authored-by: Dipika Bhattacharya <[email protected]>
…ndex.md Co-authored-by: Dipika Bhattacharya <[email protected]>
Co-authored-by: Dipika Bhattacharya <[email protected]>
…ndex.md Co-authored-by: Dipika Bhattacharya <[email protected]>
…ndex.md Co-authored-by: Dipika Bhattacharya <[email protected]>
…age/index.md Co-authored-by: Dipika Bhattacharya <[email protected]>
Co-authored-by: Dipika Bhattacharya <[email protected]>
Co-authored-by: Dipika Bhattacharya <[email protected]>
Co-authored-by: Dipika Bhattacharya <[email protected]>
@dipikabh I've done both of these. For the second one, I've made sure the key/value --> key-value change has been made everywhere, but just in the shared storage api docs. Looking at the rest of MDN, it looks like key/value is still used everywhere. Are the changes made in this PR part of a larger effort to standardize on key-value everywhere? |
Thank you!
That's an interesting question. I came across key/value in this PR. My preference leans towards key-value and a quick search indicated that the hyphenated form has been used elsewhere, so I was okay to make the suggestion. It appears that both 'key-value' (88) and 'key/value' (96) are in use across our docs. To the best of my knowledge, there is no ongoing effort to standardize this usage. I'll take a quick look again at the PR shortly and we should be able to get this one through today |
Ah, so it is used in other places on the site too! OK, all good then. We should maybe agree on a standard for this one day, but it doesn't have to be today.
Lovely, cheers! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @chrisdavidmills, thanks for the updates and addressing all the suggestions.
I like that you quote your edited text if it is different from the suggestion. It helps me quickly go through any outstanding changes I should look at. I've started following this style in my PRs as well 🙂.
I'm leaving a +1 here, but I'll leave it for you to merge in case you want to update the text for these two comments:
#30427 (comment)
#30427 (comment)
@dipikabh I've only recently started doing that as well; pretty useful huh. I've addressed the further couple of minor changes you suggested, and now I think we're ready to merge. Thanks so much for the detailed review! |
Description
#28051 contains the engineering technical review for my work on the Shared Storage API docs, which has been completed and approved. Thank you to @pythagoraskitty for your thorough and detailed review work.
This is a new PR based on the same branch, which is intended to contain the editorial review for the same work.
Background information
The Shared Storage API is an integral part of Google's privacy sandbox technologies. Many parts of this set are being made available by default in Chrome 117 (depending on a gradual ramp-up to 100% of userbase over the 117 release period).
This PR adds content for Shared Storage. See my research document for information on exactly what features are being added.
Motivation
Additional details
Related issues and pull requests