New css module: CSS syntax. Partially deprecated charset. #30793

estelle · 2023-12-05T09:08:07Z

The original task was to update the charset module. Turns out there is no such thing.
Charset was defined in CSS 2 but removed in the CSS syntax module.

Move css_charset to css_syntax.
Created a new document: css_syntax. This is a module landing page. It include the key concepts introduced in that module.
Created a new document: a guide on CSS error handling by the parser. a subpage for CSS syntax.
Updated the @charset page to indicate that it is NOT an at-rule, and has been deprecated in css-syntax.
Updated custom-ident, the page that had the best explanation of CSS escape characters, adding a separate section for escaping characters in CSS. This PR does not include creating links to that section. That will be done as a separate PR (this PR is already big enough)

related to openwebdocs/project#186

github-actions · 2023-12-05T09:11:25Z

Preview URLs

External URLs (1)

URL: /en-US/docs/Web/CSS/custom-ident
Title: <custom-ident>

https://en.wikipedia.org/wiki/Case_sensitivity (2 times) (Note! This may be a new URL 👀)

(comment last updated: 2023-12-15 06:03:04)

teoli2003 · 2023-12-07T10:36:51Z

I have a question: browsers are supporting @charset means they don't complain about the syntax but ignore it or are they actually doing something different if we have @charset "UTF-8" and `@charset "iso-8859-15"?

estelle · 2023-12-07T22:06:14Z

I have a question: browsers are supporting @charset means they don't complain about the syntax but ignore it or are they actually doing something different if we have @charset "UTF-8" and `@charset "iso-8859-15"?

It's been removed from the specification, so it's not in the module other than to say it's not needed, so not including it in the ist of properties introduced or defined in the specification/module. Added a sentence to the charset page, so people know the status, but it's in all browsers, so the deprecation is a spec thing, not an implementation thing.... yet.

Co-authored-by: Dipika Bhattacharya <[email protected]>

files/en-us/web/css/css_syntax/index.md

files/en-us/web/css/css_syntax/error_handling/index.md

files/en-us/web/css/@charset/index.md

files/en-us/web/css/css_syntax/error_handling/index.md

files/en-us/web/css/css_syntax/index.md

files/en-us/web/css/custom-ident/index.md

Co-authored-by: Dipika Bhattacharya <[email protected]>

files/en-us/web/css/css_syntax/index.md

files/en-us/web/css/css_syntax/error_handling/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

files/en-us/web/css/css_syntax/error_handling/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Unblocking the review on this one as I am going to be away for a bit

@charset

* New page: CSS syntax error handling * deprecate @charset and list as a rule not at-rule * Define character encoding * New page: error handling * New page: css syntax module * delete charset module. move to syntax module * still supported * table of contents * better grammar * better grammar * better grammar * better grammar * Apply suggestions from code review Co-authored-by: Dipika Bhattacharya <[email protected]> * added a few more notes - prefixes * edits per review * change h2 to h3 * Apply suggestions from code review Co-authored-by: Dipika Bhattacharya <[email protected]> * add guide to module page. * change UA to browser * address #30793 (comment) * hyphens to underscores * rewrote the at-rule section * rewrite grammar section * fixing linter suggestions Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * final tweaks * Update files/en-us/web/css/css_syntax/error_handling/index.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update files/en-us/web/css/css_syntax/error_handling/index.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix flaws * closed comments * borked so fixed * trailing spaces Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update files/en-us/web/css/css_syntax/error_handling/index.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update files/en-us/web/css/css_syntax/index.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Small punctuation fixes * Apply suggestions from code review Co-authored-by: Chris Mills <[email protected]> * header for at-rule * updates based on review feedback * link to display property * Apply suggestions from code review Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update files/en-us/web/css/css_syntax/error_handling/index.md * Update files/en-us/web/css/css_syntax/index.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Fix broken links * typo fix --------- Co-authored-by: Dipika Bhattacharya <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Chris Mills <[email protected]>

@charset

* New page: CSS syntax error handling * deprecate @charset and list as a rule not at-rule * Define character encoding * New page: error handling * New page: css syntax module * delete charset module. move to syntax module * still supported * table of contents * better grammar * better grammar * better grammar * better grammar * Apply suggestions from code review Co-authored-by: Dipika Bhattacharya <[email protected]> * added a few more notes - prefixes * edits per review * change h2 to h3 * Apply suggestions from code review Co-authored-by: Dipika Bhattacharya <[email protected]> * add guide to module page. * change UA to browser * address mdn#30793 (comment) * hyphens to underscores * rewrote the at-rule section * rewrite grammar section * fixing linter suggestions Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * final tweaks * Update files/en-us/web/css/css_syntax/error_handling/index.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update files/en-us/web/css/css_syntax/error_handling/index.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix flaws * closed comments * borked so fixed * trailing spaces Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update files/en-us/web/css/css_syntax/error_handling/index.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update files/en-us/web/css/css_syntax/index.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Small punctuation fixes * Apply suggestions from code review Co-authored-by: Chris Mills <[email protected]> * header for at-rule * updates based on review feedback * link to display property * Apply suggestions from code review Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update files/en-us/web/css/css_syntax/error_handling/index.md * Update files/en-us/web/css/css_syntax/index.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Fix broken links * typo fix --------- Co-authored-by: Dipika Bhattacharya <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Chris Mills <[email protected]>

estelle added 6 commits December 4, 2023 20:29

New page: CSS syntax error handling

df11dae

deprecate @charset and list as a rule not at-rule

e9bffa8

Define character encoding

d5f1733

New page: error handling

bddc9a2

New page: css syntax module

9ff78fc

delete charset module. move to syntax module

1c099d5

estelle requested review from a team as code owners December 5, 2023 09:08

estelle requested review from dipikabh and removed request for a team December 5, 2023 09:08

github-actions bot added the Content:CSS Cascading Style Sheets docs label Dec 5, 2023

estelle added 6 commits December 5, 2023 11:57

still supported

df627d9

table of contents

9b2da17

better grammar

bd5f752

better grammar

10d57b2

better grammar

2d832cf

better grammar

3afcdbd

dipikabh self-assigned this Dec 7, 2023

This comment was marked as resolved.

Sign in to view

estelle and others added 2 commits December 7, 2023 15:14

Apply suggestions from code review

e1424fb

Co-authored-by: Dipika Bhattacharya <[email protected]>

added a few more notes - prefixes

4691893

estelle commented Dec 7, 2023

View reviewed changes

files/en-us/web/css/css_syntax/index.md Outdated Show resolved Hide resolved

estelle added 2 commits December 7, 2023 15:53

edits per review

245d126

change h2 to h3

24772a4

This comment was marked as resolved.

Sign in to view

dipikabh previously requested changes Dec 11, 2023

View reviewed changes

Apply suggestions from code review

4d5c582

Co-authored-by: Dipika Bhattacharya <[email protected]>

estelle commented Dec 13, 2023

View reviewed changes

files/en-us/web/css/css_syntax/index.md Show resolved Hide resolved

add guide to module page.

71944f1

github-actions bot reviewed Dec 13, 2023

View reviewed changes

files/en-us/web/css/css_syntax/index.md Show resolved Hide resolved

files/en-us/web/css/css_syntax/index.md Show resolved Hide resolved

estelle added 4 commits December 13, 2023 13:27

change UA to browser

e287842

address mdn#30793 (comment)

50c42ce

hyphens to underscores

1ea3167

rewrote the at-rule section

e0f68c2

github-actions bot reviewed Dec 14, 2023

View reviewed changes

rewrite grammar section

ab85e39

github-actions bot reviewed Dec 15, 2023

View reviewed changes

files/en-us/web/css/css_syntax/error_handling/index.md Show resolved Hide resolved

fixing linter suggestions

53a33f3

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

dipikabh removed their assignment Dec 15, 2023

final tweaks

debf7a9

estelle requested a review from dipikabh December 15, 2023 00:58

github-actions bot reviewed Dec 15, 2023

View reviewed changes

files/en-us/web/css/css_syntax/error_handling/index.md Outdated Show resolved Hide resolved

files/en-us/web/css/css_syntax/error_handling/index.md Outdated Show resolved Hide resolved

estelle and others added 3 commits December 14, 2023 16:59

Update files/en-us/web/css/css_syntax/error_handling/index.md

a1c3201

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update files/en-us/web/css/css_syntax/error_handling/index.md

496af3c

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

fix flaws

9d13c82

closed comments

30db514

estelle closed this Dec 15, 2023

This was referenced Dec 15, 2023

CSS Module: syntax (and error handling guide) #31022

Closed

CSS syntax module and error handling #31076

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New css module: CSS syntax. Partially deprecated charset. #30793

New css module: CSS syntax. Partially deprecated charset. #30793

estelle commented Dec 5, 2023 •

edited

Loading

github-actions bot commented Dec 5, 2023 •

edited

Loading

teoli2003 commented Dec 7, 2023

estelle commented Dec 7, 2023

This comment was marked as resolved.

This comment was marked as resolved.

New css module: CSS syntax. Partially deprecated charset. #30793

New css module: CSS syntax. Partially deprecated charset. #30793

Conversation

estelle commented Dec 5, 2023 • edited Loading

github-actions bot commented Dec 5, 2023 • edited Loading

teoli2003 commented Dec 7, 2023

estelle commented Dec 7, 2023

This comment was marked as resolved.

This comment was marked as resolved.

estelle commented Dec 5, 2023 •

edited

Loading

github-actions bot commented Dec 5, 2023 •

edited

Loading