Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): migrate to husky v9 #31964

Merged
merged 2 commits into from
Jan 29, 2024
Merged

fix(ci): migrate to husky v9 #31964

merged 2 commits into from
Jan 29, 2024

Conversation

OnkarRuikar
Copy link
Contributor

@OnkarRuikar OnkarRuikar commented Jan 28, 2024

Husky was updated to V9 yesterday. Migrating as instructed in the release notes.

husky install is deprecated. Using husky || true as suggested in their docs.

Sourcing husky.sh is redundant now. Because the auto generated file, during husky installation, is empty.

⚠️ I suggest all to run yarn install and yarn prepare after pulling this change.

@OnkarRuikar OnkarRuikar requested review from mdn-bot and a team as code owners January 28, 2024 11:25
@OnkarRuikar OnkarRuikar requested review from pepelsbey and removed request for a team January 28, 2024 11:25
@github-actions github-actions bot added system [PR only] Infrastructure and configuration for the project size/xs [PR only] 0-5 LoC changed labels Jan 28, 2024
@github-actions github-actions bot added size/s [PR only] 6-50 LoC changed and removed size/xs [PR only] 0-5 LoC changed labels Jan 28, 2024
@queengooborg queengooborg merged commit 7eab8d4 into mdn:main Jan 29, 2024
14 of 15 checks passed
@OnkarRuikar OnkarRuikar deleted the ci_husky_v9 branch January 29, 2024 07:47
@yin1999
Copy link
Member

yin1999 commented Jan 30, 2024

Hey @OnkarRuikar. Could you make the same changes in mdn/translated-content?

@OnkarRuikar
Copy link
Contributor Author

Hey @OnkarRuikar. Could you make the same changes in mdn/translated-content?

Done in mdn/translated-content#18093 o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/s [PR only] 6-50 LoC changed system [PR only] Infrastructure and configuration for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants