FF Project issues template #32828
FF Project issues template #32828
Conversation
github-actions
bot
added
the
system
|
Yeh +1 from me aswell - thanks @hamishwillee |
@caugner Good idea, but since I have never touched the CODEOWNERS file before, can you please confirm that I have done this "as you wish" before I merge? |
|
@hamishwillee I think the change needed to be made to the following line in the "CONTROL FILES OWNER(S)" section:
@caugner can confirm. |
.github/CODEOWNERS
Outdated
| # ---------------------------------------------------------------------------- | ||
| # GITHUB WORKFLOW OWNER(S) | ||
| # ---------------------------------------------------------------------------- | ||
| /.github/ @mdn/yari-content-mdn |
There was a problem hiding this comment.
To be specific to the templates:
| /.github/ @mdn/yari-content-mdn | |
| /.github/ISSUE_TEMPLATE/ff-project-issue.md @mdn/core-yari-content |
There was a problem hiding this comment.
I was almost thinking of only change the code owner for ff-project-issue.md, because the other two issue templates are referenced in yari, so the devs might want to know and approve changes. Wdyt?
There was a problem hiding this comment.
Would this on line 77 take precedence?
/.github/ @mdn/core-dev
- If yes, should we be changing that line instead of adding this new section?
- Also consider:
core-yari-contentoryari-content-mdn?
There was a problem hiding this comment.
Would this on line 77 take precedence?
Yes it does, later rules override previous ones, so this issue template addition has to appear after
.github/CODEOWNERS
Outdated
| @@ -16,6 +16,11 @@ | |||
| # ---------------------------------------------------------------------------- | |||
| /files/en-us/ @mdn/yari-content-mdn | |||
|
|
|||
| # ---------------------------------------------------------------------------- | |||
| # GITHUB WORKFLOW OWNER(S) | |||
There was a problem hiding this comment.
| # GITHUB WORKFLOW OWNER(S) | |
| # ISSUE TEMPLATES |
Thanks, I wasn't sure if the comment was that MDN own the templates or the whole github workflow. @caugner Can you confirm your intent? |
hamishwillee
force-pushed
the
hamishwillee-patch-2
branch
from
4c22e78
to
c3a83f2
Compare
|
Thanks, all. Going to merge now! |
This updates the FF project issues template in line with current way of working. FYI @bsmth @Rumyra @dipikabh @pepelsbey @dletorey