Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix globals, part 6: performance #33339

Merged
merged 9 commits into from
May 6, 2024
Merged

Fix globals, part 6: performance #33339

merged 9 commits into from
May 6, 2024

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Apr 30, 2024 •
edited
Loading

/cc @wbamberg

part of the #33019

@github-actions github-actions bot added Content:WebAPI Web API docs Content:JS JavaScript docs system [PR only] Infrastructure and configuration for the project size/m [PR only] 51-500 LoC changed labels Apr 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 30, 2024 •
edited
Loading

Preview URLs (9 pages)
Flaws (1)

Note! 8 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/Performance_API/Performance_data
Title: Performance data
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/API/Performance_API/Element_timing

(comment last updated: 2024-05-06 17:07:32)

skyclouds2001
skyclouds2001 commented Apr 30, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the system [PR only] Infrastructure and configuration for the project label Apr 30, 2024
@skyclouds2001 skyclouds2001 marked this pull request as ready for review April 30, 2024 18:58
@skyclouds2001 skyclouds2001 requested review from a team as code owners April 30, 2024 18:58
@skyclouds2001 skyclouds2001 requested review from Elchi3 and pepelsbey and removed request for a team April 30, 2024 18:58
@skyclouds2001 skyclouds2001 mentioned this pull request Apr 30, 2024
Merged
wbamberg
wbamberg requested changes May 4, 2024
View reviewed changes
files/en-us/web/api/performance_api/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/performance_api/performance_data/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/window/performance/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/window/performance/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/workerglobalscope/performance/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/workerglobalscope/performance/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/workerglobalscope/performance/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/window/performance/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/performance/index.md Outdated Show resolved Hide resolved
wbamberg
wbamberg approved these changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks great, thank you @skyclouds2001 !

@wbamberg @github-actions
Update files/en-us/web/api/workerglobalscope/index.md
bf5c40f 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@wbamberg wbamberg merged commit 54962bb into mdn:main May 6, 2024
9 checks passed
@yin1999 yin1999 mentioned this pull request May 7, 2024
Closed
3 tasks
@skyclouds2001 skyclouds2001 deleted the performance branch May 7, 2024 04:46
@skyclouds2001 skyclouds2001 changed the title Fix globals, part 6: performance Fix globals, part 6: performance May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@wbamberg wbamberg wbamberg approved these changes

@Elchi3 Elchi3 Awaiting requested review from Elchi3 Elchi3 is a code owner automatically assigned from mdn/yari-content-web-api

@pepelsbey pepelsbey Awaiting requested review from pepelsbey pepelsbey is a code owner automatically assigned from mdn/core-yari-content

Assignees
No one assigned
Labels
Content:JS JavaScript docs Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skyclouds2001 @wbamberg