Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS property update: gap #34141

Merged
merged 5 commits into from
Jun 20, 2024
Merged

CSS property update: gap #34141

merged 5 commits into from
Jun 20, 2024

Conversation

estelle
Copy link
Member

@estelle estelle commented Jun 14, 2024

  • add applicable properties
  • add description (with flex direction explanation)
  • see also

addressed as part of CSS baseline / interop openwebdocs/project#189 - subcomponent openwebdocs/project#202

@estelle estelle requested a review from a team as a code owner June 14, 2024 03:54
@estelle estelle requested review from dipikabh and removed request for a team June 14, 2024 03:54
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/s [PR only] 6-50 LoC changed labels Jun 14, 2024
@estelle estelle mentioned this pull request Jun 14, 2024
29 tasks
Copy link
Contributor

github-actions bot commented Jun 14, 2024

Preview URLs

(comment last updated: 2024-06-20 18:44:22)

dipikabh

This comment was marked as outdated.

estelle

This comment was marked as outdated.

@estelle estelle requested a review from dipikabh June 18, 2024 17:04
files/en-us/web/css/gap/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/gap/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/gap/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/gap/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/gap/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/gap/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/gap/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/gap/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/gap/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/gap/index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @estelle. I've looked at the updates.

files/en-us/web/css/gap/index.md Outdated Show resolved Hide resolved

The visible space between elements may differ from the specified `gap` value because margins, padding, and distributed alignment may increase the separation between elements beyond what is specified by `gap`.

Early versions of the specification called this property `grid-gap`, and to maintain compatibility with legacy websites, browsers still accept `grid-gap` as an alias for `gap`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think placing this historical info at the beginning of the "Description" section might be better for the flow of content.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better at the end because it's not important; whereas placing it at the beginning adds importance.

Co-authored-by: Dipika Bhattacharya <[email protected]>
@estelle estelle requested a review from dipikabh June 20, 2024 18:43
@dipikabh dipikabh merged commit b118a17 into main Jun 20, 2024
9 checks passed
@dipikabh dipikabh deleted the flex-gap branch June 20, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants