Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: CSS flex guide: updates to guide 4 #34183

Merged
merged 3 commits into from
Jun 17, 2024
Merged

Maintenance: CSS flex guide: updates to guide 4 #34183

merged 3 commits into from
Jun 17, 2024

Conversation

estelle
Copy link
Member

@estelle estelle commented Jun 15, 2024

Flexbox is well-supported. This update freshens up the guide, removing 'history' and 'browser support' stuff.

updating guide as part of CSS baseline / interop openwebdocs/project#189 - subcomponent openwebdocs/project#202

@estelle estelle requested a review from a team as a code owner June 15, 2024 08:21
@estelle estelle requested review from bsmth and removed request for a team June 15, 2024 08:21
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Jun 15, 2024
@github-actions github-actions bot added the size/m [PR only] 51-500 LoC changed label Jun 15, 2024
@estelle estelle mentioned this pull request Jun 15, 2024
29 tasks
Copy link
Contributor

github-actions bot commented Jun 15, 2024

Preview URLs

External URLs (3)

URL: /en-US/docs/Web/CSS/CSS_flexible_box_layout/Ordering_flex_items
Title: Ordering flex items

(comment last updated: 2024-06-17 13:52:33)

Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion and an open question at the end for clarity, maybe you have better phrasing for the existing sentence. Otherwise looking great, so leaving a +1

Thank you!

Co-authored-by: Brian Thomas Smith <[email protected]>
@estelle estelle merged commit 0800ba8 into main Jun 17, 2024
9 checks passed
@estelle estelle deleted the flex-guide4 branch June 17, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants