Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(css): simplify unlayered style description #34345

Merged
merged 5 commits into from
Jun 25, 2024
Merged

fix(css): simplify unlayered style description #34345

merged 5 commits into from
Jun 25, 2024

Conversation

OnkarRuikar
Copy link
Contributor

Current prose beat around bush and ends explaining implementation. The PR simplifies the statement as per the request.

@OnkarRuikar OnkarRuikar requested a review from a team as a code owner June 22, 2024 11:33
@OnkarRuikar OnkarRuikar requested review from chrisdavidmills and removed request for a team June 22, 2024 11:33
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/xs [PR only] 0-5 LoC changed labels Jun 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 22, 2024 •
edited
Loading

Preview URLs

Flaws (1)

URL: /en-US/docs/Web/CSS/@layer
Title: @layer
Flaw count: 1

  • images:
    • External image URL

(comment last updated: 2024-06-25 08:00:03)

@github-actions github-actions bot added size/s [PR only] 6-50 LoC changed and removed size/xs [PR only] 0-5 LoC changed labels Jun 22, 2024
chrisdavidmills
chrisdavidmills approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OnkarRuikar looking pretty good to me. Approving, pending the diagram update and the paragraph update I suggested.

files/en-us/web/css/@layer/index.md Outdated Show resolved Hide resolved
bsmth
bsmth requested changes Jun 24, 2024
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should move the png into the shared assets repo as an SVG, if you need some help, let me know!

@bsmth
Copy link
Member

bsmth commented Jun 24, 2024

We should move the png into the shared assets repo as an SVG, if you need some help, let me know!

Just discussed in the community call, I can recreate the diagram for you. Hold tight for a PR in the shared-assets repo.

@bsmth bsmth mentioned this pull request Jun 24, 2024
Merged
bsmth
bsmth reviewed Jun 25, 2024
View reviewed changes
files/en-us/web/css/@layer/index.md Outdated

The following diagram shows layer priorities where layers are declared in 1, 2, ..., N order.

![Diagram showing cascade layer priorities](layer_cascade.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
![Diagram showing cascade layer priorities](layer_cascade.png)
![Diagram showing cascade layer priorities](https://mdn.github.io/shared-assets/images/diagrams/css/at-rules/layer-cascade.svg)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsmth The new URL is giving the following error in page preview:

Refused to load the image 'https://mdn.github.io/shared-assets/images/diagrams/css/at-rules/layer-cascade.svg' because it violates the following Content Security Policy directive: "img-src 'self' *.githubusercontent.com *.googleusercontent.com *.gravatar.com mozillausercontent.com firefoxusercontent.com profile.stage.mozaws.net profile.accounts.firefox.com media.prod.mdn.mozit.cloud media.stage.mdn.mozit.cloud interactive-examples.mdn.mozilla.net interactive-examples.mdn.allizom.net wikipedia.org www.google-analytics.com www.gstatic.com".

Will it work on live site?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a known bug, CSP rules have to be updated on dev (preview) env. They have been added in prod via Yari. See https://developer.mozilla.org/en-US/docs/Web/HTTP/Overview for example.

bsmth
bsmth approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

@bsmth bsmth merged commit d12bbb3 into mdn:main Jun 25, 2024
8 checks passed
@OnkarRuikar OnkarRuikar deleted the css_unlayered branch June 25, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josh-Cena Josh-Cena Josh-Cena left review comments

@bsmth bsmth bsmth approved these changes

@chrisdavidmills chrisdavidmills chrisdavidmills approved these changes

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Description of @layer
4 participants
@OnkarRuikar @bsmth @chrisdavidmills @Josh-Cena