Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting corrections #34365

Merged
merged 9 commits into from
Jun 25, 2024
Merged

Formatting corrections #34365

merged 9 commits into from
Jun 25, 2024

Conversation

yahyavaleo
Copy link
Contributor

Description

Corrected some formatting mistakes

Motivation

Besides some small formatting corrections, on page How CSS is structured there are a lot of things that should not be bold.

As they currently are, it is very distracting and overwhelming to the eyes.

Also there was a comment line (---------) that was too long and overflowed into three lines on even my screen (1920 pixels wide), so I shortened it to appropriate length.

Additional details

N/A

Related issues and pull requests

N/A

@yahyavaleo yahyavaleo requested a review from a team as a code owner June 24, 2024 02:22
@yahyavaleo yahyavaleo requested review from dipikabh and removed request for a team June 24, 2024 02:22
@github-actions github-actions bot added Content:Learn:CSS Learning area CSS docs size/m [PR only] 51-500 LoC changed labels Jun 24, 2024
Copy link
Contributor

github-actions bot commented Jun 24, 2024

Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yahyavaleo Thanks for this.

While I personally find these changes helpful, FYI we don't normally accept pure-stylistic and layout changes that aren't fixing things that are actually technically wrong or ambiguous. That's because the reviewer team is small, and we need to prioritise fixes that make the most difference for readers.
Certainly you may find that reviews take a lot longer for things like this.

If you're looking for places to help , any issue labeled with "good first issue" is a good place to start.

@hamishwillee hamishwillee merged commit 4b543d2 into mdn:main Jun 25, 2024
8 checks passed
@yahyavaleo yahyavaleo deleted the patch-1 branch June 25, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Learn:CSS Learning area CSS docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants