Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo #34384

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Fix typo #34384

merged 1 commit into from
Jun 25, 2024

Conversation

in-in
Copy link
Contributor

@in-in in-in commented Jun 24, 2024

Description

Fix method name

Motivation

Additional details

Related issues and pull requests

@in-in in-in requested a review from a team as a code owner June 24, 2024 18:36
@in-in in-in requested review from sideshowbarker and removed request for a team June 24, 2024 18:36
@github-actions github-actions bot added Content:WebAPI Web API docs size/xs [PR only] 0-5 LoC changed labels Jun 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

Preview URLs

Flaws (1)

URL: /en-US/docs/Web/API/RTCPeerConnection/setIdentityProvider
Title: RTCPeerConnection: setIdentityProvider() method
Flaw count: 1

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Web/API/RTCRtpCodecParameters

@sideshowbarker sideshowbarker removed their request for review June 24, 2024 19:49
hamishwillee
hamishwillee approved these changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@in-in Thank you - good catch.

@hamishwillee hamishwillee merged commit 310ee01 into mdn:main Jun 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamishwillee hamishwillee hamishwillee approved these changes

Assignees
No one assigned
Labels
Content:WebAPI Web API docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@in-in @hamishwillee