Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#26912 Glossary: Baseline #34385

Merged
merged 6 commits into from
Jul 12, 2024
Merged

#26912 Glossary: Baseline #34385

merged 6 commits into from
Jul 12, 2024

Conversation

estelle
Copy link
Member

@estelle estelle commented Jun 24, 2024

suggested solution for #26912

@estelle estelle requested a review from a team as a code owner June 24, 2024 18:53
@estelle estelle requested review from hamishwillee and removed request for a team June 24, 2024 18:53
@github-actions github-actions bot added the Content:Glossary Glossary entries label Jun 24, 2024
@estelle estelle marked this pull request as draft June 24, 2024 18:53
@github-actions github-actions bot added the size/s [PR only] 6-50 LoC changed label Jun 24, 2024
Copy link
Contributor

github-actions bot commented Jun 24, 2024

Preview URLs

External URLs (2)

URL: /en-US/docs/Glossary/Baseline/Compatibility
Title: Baseline (compatibility)

(comment last updated: 2024-07-04 08:56:51)

@hamishwillee
Copy link
Collaborator

hamishwillee commented Jun 25, 2024

@ddbeck Is this something you would like to review (when it is done)? I see from your comments on #26912 (comment) that you have opinions, while I do not.

@Rumyra
Copy link
Collaborator

Rumyra commented Jun 25, 2024

Thanks for the pr @estelle - I'd like to keep this drafted while we discuss where the banners should link to (if the glossary page doesn't explain what baseline is that's a larger discussion than we anticipated) - we have a meeting on Thursday and I should be able to confirm more then

@Rumyra Rumyra requested review from Rumyra and removed request for hamishwillee June 25, 2024 08:39
@ddbeck
Copy link
Contributor

ddbeck commented Jun 25, 2024

@hamishwillee @estelle Yes, I'd like to have a look at this when it's not a draft. Thank you!

@estelle
Copy link
Member Author

estelle commented Jun 25, 2024

@ddbeck @Rumyra This is just a draft for discussion; figured this was the best way to review / get to issue resolution / provide suggestion and feedback

@estelle estelle changed the title #26912 Draft: Glossary: Baseline #26912 Glossary: Baseline Jul 3, 2024
@estelle estelle marked this pull request as ready for review July 3, 2024 01:39
@estelle
Copy link
Member Author

estelle commented Jul 3, 2024

@Rumyra @ddbeck I pull this out of "draft" and switched to "ready for review" as no one expressed any concerns. Feel free to review, or put back in draft and discuss. Thanks.

Copy link
Contributor

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for my tardiness in reviewing. Thank you for considering this, Estelle!

files/en-us/glossary/baseline/compatibility/index.md Outdated Show resolved Hide resolved
files/en-us/glossary/baseline/compatibility/index.md Outdated Show resolved Hide resolved

If Baseline doesn't cover your situation, you can find more information in the browser compatibility tables on MDN, [caniuse.com](https://caniuse.com/), and [a11ysupport.io](https://a11ysupport.io/).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a direct suggestion here, except to say that acknowledging that Baseline is not the only source of information on this stuff, particularly on the non-browser accessibility support, was essential to previous edits to this page.

files/en-us/glossary/baseline/compatibility/index.md Outdated Show resolved Hide resolved
files/en-us/glossary/baseline/compatibility/index.md Outdated Show resolved Hide resolved
@github-actions github-actions bot added size/m [PR only] 51-500 LoC changed and removed size/s [PR only] 6-50 LoC changed labels Jul 4, 2024
@estelle
Copy link
Member Author

estelle commented Jul 4, 2024

@ddbeck i committed your suggestions and added caniuse and a11yio to the see also section

@estelle estelle requested a review from ddbeck July 4, 2024 08:56
Copy link
Contributor

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good enough for me. Thank you!

@Josh-Cena
Copy link
Member

@Rumyra Could you review this?

@Rumyra
Copy link
Collaborator

Rumyra commented Jul 12, 2024

Thanks both - as @ddbeck is happy so am I - merging

@Rumyra Rumyra merged commit 70aa041 into main Jul 12, 2024
9 checks passed
@Rumyra Rumyra deleted the estelle-patch-2 branch July 12, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Glossary Glossary entries size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants