fix(api): Use internal example in KeyFrameEffect pages

[OnkarRuikar]

• fixes KeyframeEffect.target: issues with the example #25694

As asked for in the issue, the PR adds examples in the KeyFrameEffect pages.

The new example makes 🤣 emojy really roll on the floor. Also, KeyframeEffect.spacing doesn't exist in specs or MDN so it's been removed.

[github-actions]

Preview URLs

• /en-US/docs/Web/API/KeyframeEffect/KeyframeEffect
• /en-US/docs/Web/API/KeyframeEffect/getKeyframes
• /en-US/docs/Web/API/KeyframeEffect/pseudoElement
• /en-US/docs/Web/API/KeyframeEffect/target
• /en-US/docs/Web/API/KeyframeEffect

(comment last updated: 2024-07-12 03:27:26)

[chrisdavidmills]

Sorry, I've had so many reviews dumped on me recently that I'm struggling to keep up with them all. I'm removing myself from a couple of them.

[bsmth]

Hey Onkar, I've added myself as a reviewer. I'll try to take a look today 🙏🏻

[bsmth]

Looking great. I have one concern that we're duplicating the code so next time we make changes, we have to update multiple places, but I'm not sure what the better option would be.

Do you have any thoughts about simplifying the KeyframeEffect/target example so it's more minimal? Getting rid of the <hr> and hiding the CSS block?

Otherwise, good to go, IMO

[OnkarRuikar]

I have one concern that we're duplicating the code so next time we make changes, we have to update multiple places, but I'm not sure what the better option would be.

Unfortunately, all the examples are not the same they have sight variations. Some log the corresponding member/function in the code.

Do you have any thoughts about simplifying the KeyframeEffect/target example so it's more minimal? Getting rid of the <hr> and hiding the CSS block?

CSS block is not relevant so I've hidden it. Got rid of <hr> too.

[bsmth]

Thanks a lot! Couple of minor suggestions for you, but I think we're ready to go when you've had a look at my comments 👍🏻

[bsmth]

Looks great! Merging now!