-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(css): update sticky positioning section #34776
Conversation
Preview URLs (comment last updated: 2024-07-16 08:48:17) |
1ca8cc8
to
37beed1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Onkar! Although I think this example is really clever, I have to say the original helps me understand position: sticky;
better. I had some trouble figuring out what I was supposed to do in the scroll box. If I compare it with the interactive example on the top of the page, the additions are a little too complex! 😄
I think we can either revert the example changes to the one that's live on prod, or we do something that's got a little less going on like an element that sticks on scroll like here: https://developer.mozilla.org/en-US/docs/Web/CSS/position#try_it
What do you think?
I've brought the original sticky heading in list example back.
I've changed the wording.
The "try it" section already covers a simple example so we don't have to repeat similar/simplar thing again. I really wanted to demo what happens when all the inset boundaries are set and how the element stays confined to the inset area. :( How about we keep the original and mine both? :) |
Thanks, Onkar!
Looks better, IMO 🙌🏻
I think that's a good idea. Having a look at prose now, but overall looking good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments for you, but leaving a +1, thank you!
Co-authored-by: Brian Thomas Smith <[email protected]>
The very first statement in the section throws heavy jargon at readers. Without knowing what sticky positioning means it's not being helpful. Rewarding the intro para in simple terms.
I think the accordion example is a bit too much for the simple intro. Replacing it with a simple one that asserts the importance of the entire inset area.