Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): update sticky positioning section #34776

Merged
merged 6 commits into from
Jul 16, 2024
Merged

Conversation

OnkarRuikar
Copy link
Contributor

The very first statement in the section throws heavy jargon at readers. Without knowing what sticky positioning means it's not being helpful. Rewarding the intro para in simple terms.

I think the accordion example is a bit too much for the simple intro. Replacing it with a simple one that asserts the importance of the entire inset area.

@OnkarRuikar OnkarRuikar requested a review from a team as a code owner July 11, 2024 10:09
@OnkarRuikar OnkarRuikar requested review from bsmth and removed request for a team July 11, 2024 10:09
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed labels Jul 11, 2024
Copy link
Contributor

github-actions bot commented Jul 11, 2024

Preview URLs

(comment last updated: 2024-07-16 08:48:17)

@OnkarRuikar OnkarRuikar force-pushed the css_sticky branch 2 times, most recently from 1ca8cc8 to 37beed1 Compare July 12, 2024 06:43
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Onkar! Although I think this example is really clever, I have to say the original helps me understand position: sticky; better. I had some trouble figuring out what I was supposed to do in the scroll box. If I compare it with the interactive example on the top of the page, the additions are a little too complex! 😄

I think we can either revert the example changes to the one that's live on prod, or we do something that's got a little less going on like an element that sticks on scroll like here: https://developer.mozilla.org/en-US/docs/Web/CSS/position#try_it

What do you think?

@OnkarRuikar
Copy link
Contributor Author

I have to say the original helps me understand position: sticky; better.

I've brought the original sticky heading in list example back.

I had some trouble figuring out what I was supposed to do in the scroll box.

I've changed the wording.

If I compare it with the interactive example on the top of the page, the additions are a little too complex! 😄

The "try it" section already covers a simple example so we don't have to repeat similar/simplar thing again. I really wanted to demo what happens when all the inset boundaries are set and how the element stays confined to the inset area. :(

How about we keep the original and mine both? :)

@OnkarRuikar OnkarRuikar requested a review from bsmth July 13, 2024 05:52
@bsmth
Copy link
Member

bsmth commented Jul 16, 2024

Thanks, Onkar!

I had some trouble figuring out what I was supposed to do in the scroll box.

I've changed the wording.

Looks better, IMO 🙌🏻

How about we keep the original and mine both? :)

I think that's a good idea. Having a look at prose now, but overall looking good!

Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments for you, but leaving a +1, thank you!

Co-authored-by: Brian Thomas Smith <[email protected]>
@OnkarRuikar OnkarRuikar requested a review from bsmth July 16, 2024 08:28
@bsmth bsmth merged commit 25ef803 into mdn:main Jul 16, 2024
8 checks passed
@OnkarRuikar OnkarRuikar deleted the css_sticky branch July 17, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Sticky positioning is a hybrid of relative and fixed positioning" is slightly confusing
2 participants