Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wrong heading #34800

Merged
merged 1 commit into from
Jul 12, 2024
Merged

fix wrong heading #34800

merged 1 commit into from
Jul 12, 2024

Conversation

PassionPenguin
Copy link
Contributor

@PassionPenguin PassionPenguin commented Jul 12, 2024

remove a (possibly) misplaced heading, as we now have the following structure in NY Times example:

while content between these two h2 got only ONE paragraph?

the heading has been here ever since cbe151a. see

<h2 id="An_approach_for_using_third-party_APIs">An approach for using third-party APIs</h2>


furthermore, the sentence (which seems to be documented in the related Leaflet.js docs) in L142 (https://github.com/mdn/content/blob/main/files/en-us/learn/javascript/client-side_web_apis/third_party_apis/index.md?plain=1#L142) seems to be...of much uncertainty?

@PassionPenguin PassionPenguin requested a review from a team as a code owner July 12, 2024 07:04
@PassionPenguin PassionPenguin requested review from Josh-Cena and removed request for a team July 12, 2024 07:04
@github-actions github-actions bot added Content:Learn:JavaScript Learning area JavaScript docs size/xs [PR only] 0-5 LoC changed labels Jul 12, 2024
Copy link
Contributor

Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@estelle estelle merged commit 3684ed0 into mdn:main Jul 12, 2024
7 checks passed
@PassionPenguin
Copy link
Contributor Author

Hi @estelle. I do consider it too casual (or to uncertain) to keep the sentence in the parentheses (which seems to be documented in the related Leaflet.js docs) in L142 (https://github.com/mdn/content/blob/main/files/en-us/learn/javascript/client-side_web_apis/third_party_apis/index.md?plain=1#L142). should we also remove it?

@PassionPenguin PassionPenguin deleted the tpai branch July 12, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Learn:JavaScript Learning area JavaScript docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants