Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New page: HTML comments #34811

Merged
merged 9 commits into from
Jul 12, 2024
Merged

New page: HTML comments #34811

merged 9 commits into from
Jul 12, 2024

Conversation

estelle
Copy link
Member

@estelle estelle commented Jul 12, 2024

fixes #21761

@estelle estelle requested a review from a team as a code owner July 12, 2024 15:55
@estelle estelle requested review from dipikabh and removed request for a team July 12, 2024 15:55
@github-actions github-actions bot added Content:HTML Hypertext Markup Language docs size/m [PR only] 51-500 LoC changed labels Jul 12, 2024
Copy link
Contributor

github-actions bot commented Jul 12, 2024

Preview URLs

(comment last updated: 2024-07-12 22:11:40)

Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually had a draft locally, but that one was far more ambitious than this one and I don't think I'll ever complete it.

Do you think we should add an example of the legacy practice of using HTML comments in <script> to prevent it from being displayed? Might be an interesting history trivia, and is the reason why we have this feature in the JS spec: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Deprecated_and_obsolete_features#html_comments

@estelle estelle requested a review from Josh-Cena July 12, 2024 18:53
@estelle estelle requested a review from Josh-Cena July 12, 2024 19:31
@estelle estelle requested a review from Josh-Cena July 12, 2024 19:51
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but still leaving the suggestion open. You can merge it if you want.

@estelle estelle merged commit bde9f2d into main Jul 12, 2024
9 checks passed
@estelle estelle deleted the comments branch July 12, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:HTML Hypertext Markup Language docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No mention of comments in reference
2 participants