-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editorial review: Add information on file system access locking modes #35334
Editorial review: Add information on file system access locking modes #35334
Conversation
Preview URLs
Flaws (1)Note! 2 documents with no flaws that don't need to be listed. 🎉 URL:
External URLs (2)URL:
URL:
(comment last updated: 2024-08-09 09:24:44) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor nits here and there.
files/en-us/web/api/filesystemfilehandle/createsyncaccesshandle/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/filesystemfilehandle/createsyncaccesshandle/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/filesystemfilehandle/createsyncaccesshandle/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/filesystemfilehandle/createsyncaccesshandle/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/filesystemfilehandle/createsyncaccesshandle/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/filesystemfilehandle/createsyncaccesshandle/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/filesystemfilehandle/createsyncaccesshandle/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/filesystemfilehandle/createsyncaccesshandle/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/filesystemfilehandle/createwritable/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/filesystemfilehandle/createwritable/index.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, the technical parts look correct to me.
files/en-us/web/api/filesystemfilehandle/createsyncaccesshandle/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/filesystemfilehandle/createwritable/index.md
Outdated
Show resolved
Hide resolved
Thanks again for the technical review, @tomayac and @nathanmemmott. At this point, it looks like all your comments have been fixed, and I'm going to take the liberty of calling this tech review closed and move this on to the editorial review stage. Feel free to add further comments if needed. |
Awesome, cheers @sideshowbarker! |
Description
Chrome 121 supports a
mode
property on the options objects that can be specified as arguments toFileSystemFileHandle.createSyncAccessHandle()
andFileSystemFileHandle.createWritable()
. See the associated ChromeStatus entry. This PR adds content to explain these new features.These features are not yet in the FileSystem API spec — see whatwg/fs#151 for the relevant PR. Consequently, I have marked them as non-standard in the associated docs.
See also the New Locking Scheme to Enable Multiple Readers and Writers explainer for more information on how it works.
Motivation
Additional details
Related issues and pull requests
Fixes mdn/mdn#479