-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update groupdata of Picture-In-Picture API & some other update #35887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Content:WebAPI
Web API docs
size/s
[PR only] 6-50 LoC changed
labels
Sep 14, 2024
Preview URLs
(comment last updated: 2024-09-20 17:37:04) |
skyclouds2001
commented
Sep 14, 2024
skyclouds2001
requested review from
Elchi3 and
bsmth
and removed request for
a team
September 14, 2024 06:45
bsmth
reviewed
Sep 19, 2024
skyclouds2001
commented
Sep 20, 2024
bsmth
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 👍🏻
fiji-flo
pushed a commit
that referenced
this pull request
Oct 2, 2024
* fix * update * update * Update files/jsondata/GroupData.json * Update index.md * Update files/en-us/web/api/picture-in-picture_api/index.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
update groupdata of Picture-In-Picture API - remove non-existed guide, add missing interface and property, remove an event as the interface it belongs to has in the list already
rewrite value section of
ShadowRoot.pictureInPictureElement
add
PictureInPictureEvent
to API interface list, and fixes in permissions-policy (seems to be conflict with fullscreen?)Motivation
Additional details
Related issues and pull requests
relates to mdn/translated-content#23557