Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update two manifest member (BCD data removed) #35926

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

skyclouds2001
Copy link
Contributor

Description

see mdn/browser-compat-data#23774, the two's BCD data is removed, but the two is still standard: so browser-compat key removed and spec-urls key added, also update Browser compatibility section with a sentence explaining the support status

Motivation

Additional details

Related issues and pull requests

@github-actions github-actions bot added Content:Manifest size/s [PR only] 6-50 LoC changed labels Sep 18, 2024
Copy link
Contributor

github-actions bot commented Sep 18, 2024

Preview URLs

(comment last updated: 2024-09-24 02:37:16)

@skyclouds2001 skyclouds2001 marked this pull request as ready for review September 18, 2024 05:44
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner September 18, 2024 05:44
@skyclouds2001 skyclouds2001 requested review from hamishwillee and removed request for a team September 18, 2024 05:44
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @skyclouds2001 for this PR! You beat me to it :)

The updates are good, just a minor nit with the wording

files/en-us/web/manifest/categories/index.md Outdated Show resolved Hide resolved
files/en-us/web/manifest/screenshots/index.md Outdated Show resolved Hide resolved
Co-authored-by: Dipika Bhattacharya <[email protected]>
@Josh-Cena
Copy link
Member

This wording implies that they should be supported by browsers but they are not. While if you read the BCD PR the motivation is "this is an app store feature and has nothing to do with browsers". Therefore we should probably say something similar to that: "Browser compatibility is irrelevant because this member is not used by browsers, but by app stores when publishing your app."

@skyclouds2001
Copy link
Contributor Author

skyclouds2001 commented Sep 21, 2024

Browser compatibility is irrelevant because this member is not used by browsers, but by app stores when publishing your app.

Agree, but I think the following will be better:

Browser compatibility is irrelevant because this feature is not used by browsers, but by app stores when publishing the app. Though some browsers may use this feature, there is no requirement for browsers to implement any form of support."

@dipikabh
Copy link
Contributor

Thanks for pointing that out @Josh-Cena, that makes sense.

We could word it as:

This manifest member is used by app stores and catalogs when publishing and listing web apps, so browser compatibility is not applicable. Browsers may parse this information, but it's optional and doesn't affect the core functionality of a web app.

@skyclouds2001, WDYT?

@skyclouds2001
Copy link
Contributor Author

Updated!

@zhowan2020
Copy link

@zhowan2020
Copy link

Duplicate of #`

Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dipikabh dipikabh merged commit e5a696e into mdn:main Sep 24, 2024
8 checks passed
@skyclouds2001 skyclouds2001 deleted the manifest-removal branch September 24, 2024 14:30
OnkarRuikar pushed a commit to OnkarRuikar/content that referenced this pull request Sep 28, 2024
* update

* Apply suggestions from code review

Co-authored-by: Dipika Bhattacharya <[email protected]>

* Apply suggestions from code review

---------

Co-authored-by: Dipika Bhattacharya <[email protected]>
fiji-flo pushed a commit that referenced this pull request Oct 2, 2024
* update

* Apply suggestions from code review

Co-authored-by: Dipika Bhattacharya <[email protected]>

* Apply suggestions from code review

---------

Co-authored-by: Dipika Bhattacharya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Manifest size/s [PR only] 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants