-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update two manifest member (BCD data removed) #35926
Conversation
Preview URLs (comment last updated: 2024-09-24 02:37:16) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @skyclouds2001 for this PR! You beat me to it :)
The updates are good, just a minor nit with the wording
Co-authored-by: Dipika Bhattacharya <[email protected]>
This wording implies that they should be supported by browsers but they are not. While if you read the BCD PR the motivation is "this is an app store feature and has nothing to do with browsers". Therefore we should probably say something similar to that: "Browser compatibility is irrelevant because this member is not used by browsers, but by app stores when publishing your app." |
Agree, but I think the following will be better:
|
Thanks for pointing that out @Josh-Cena, that makes sense. We could word it as:
@skyclouds2001, WDYT? |
Updated! |
Duplicate of #` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
* update * Apply suggestions from code review Co-authored-by: Dipika Bhattacharya <[email protected]> * Apply suggestions from code review --------- Co-authored-by: Dipika Bhattacharya <[email protected]>
* update * Apply suggestions from code review Co-authored-by: Dipika Bhattacharya <[email protected]> * Apply suggestions from code review --------- Co-authored-by: Dipika Bhattacharya <[email protected]>
Description
see mdn/browser-compat-data#23774, the two's BCD data is removed, but the two is still standard: so
browser-compat
key removed andspec-urls
key added, also update Browser compatibility section with a sentence explaining the support statusMotivation
Additional details
Related issues and pull requests