-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(manifest): Improvements to orientation
page
#35977
Conversation
Preview URLs (comment last updated: 2024-10-01 16:20:54) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dipikabh! Thanks for your awesome work on this, such an improvement on the existing manifest pages. I love that you are taking this on.
I have some comments for you — mostly not serious.
This pull request has merge conflicts that must be resolved before it can be merged. |
5490499
to
54c2cf5
Compare
Hi Chris, thanks for the excellent review suggestions and questions. I ended up redoing a lot of content, so it took a bit longer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dipikabh wonderful work, Dipika. I just noticed a couple more small typos. Approving, so you can merge when you've considered those.
Thanks @chrisdavidmills for taking a look at all the updates and going through the page again. Merging this shortly. |
Description
This work is part of improving the web/manifest docs.
Apart from normalizing the page layout to include "Syntax" and "Values", this PR includes the following changes:
Motivation
To ensure all sections have sufficient explanation, all caveats from spec are covered, and the pages follow a similar template
Additional details
Spec links:
Related issues and pull requests
Tracking issue: mdn/mdn#560
Fixes #34927