Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(css): Move CSS examples - Learn area tasks / assessments #36688

Merged
merged 24 commits into from
Nov 8, 2024

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Nov 7, 2024

Description

This PR moves tasks (Test your skills) in the Learn area from external examples into the content.

Removals:

  • Pages do not link to download starting point

Additions:

  • Marking hints are moved under the examples at <details> elements to show/hide solutions
  • See also section, (currently links to CSS building blocks)
  • Admonition mentions that you can click "Play" to break example out into an editor

Changes:

Converts the following macros to live samples:

{{EmbedGHLiveSample("css-examples/learn/tasks/box-model/box-models.html", '100%', 1100)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/box-model/inline-block.html", '100%', 800)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/cascade/cascade.html", '100%', 700)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/cascade/cascadelayer.html", '100%', 700)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/images/object-fit.html", '100%', 1000)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/images/form.html", '100%', 600)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/overflow/overflow-scroll.html", '100%', 1000)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/overflow/overflow-hidden.html", '100%', 1200)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/selectors/type.html", '100%', 700)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/selectors/class-id.html", '100%', 800)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/selectors/pseudo.html", '100%', 800)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/selectors/combinators.html", '100%', 800)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/selectors/attribute-links.html", '100%', 800)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/sizing/height-min-height.html", '100%', 1000)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/sizing/percentages.html", '100%', 800)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/sizing/max-width.html", '100%', 1200)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/tables/table.html", '100%', 1000)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/backgrounds/backgrounds1.html", '100%', 700)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/backgrounds/backgrounds2.html", '100%', 700)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/values/color.html", '100%', 1000)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/values/length.html", '100%', 1000)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/values/position.html", '100%', 800)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/writing-modes/writing-mode.html", '100%', 800)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/writing-modes/logical-width-height.html", '100%', 1100)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/writing-modes/logical-mbp.html", '100%', 1100)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/flexbox/flexbox1.html", '100%', 700)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/flexbox/flexbox2.html", '100%', 800)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/flexbox/flexbox3.html", '100%', 800)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/flexbox/flexbox4.html", '100%', 1100)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/float/float1.html", '100%', 900)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/float/float2.html", '100%', 800)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/float/float3.html", '100%', 800)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/grid/grid1.html", '100%', 700)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/grid/grid2.html", '100%', 900)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/grid/grid3.html", '100%', 800)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/grid/grid4.html", '100%', 2000)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/multicol/multicol1.html", '100%', 1000)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/multicol/multicol2.html", '100%', 1000)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/multicol/multicol3.html", '100%', 1000)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/position/position1.html", '100%', 1000)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/position/position2.html", '100%', 1300)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/box-model/box-models.html", '100%', 1100)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/box-model/mbp.html", '100%', 600)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/box-model/inline-block.html", '100%', 800)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/cascade/cascade.html", '100%', 700)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/cascade/cascadelayer.html", '100%', 700)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/images/object-fit.html", '100%', 1000)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/images/form.html", '100%', 600)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/overflow/overflow-scroll.html", '100%', 1000)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/overflow/overflow-hidden.html", '100%', 1200)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/selectors/type.html", '100%', 700)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/selectors/class-id.html", '100%', 800)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/selectors/pseudo.html", '100%', 800)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/selectors/combinators.html", '100%', 800)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/selectors/attribute-links.html", '100%', 800)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/sizing/height-min-height.html", '100%', 1000)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/sizing/percentages.html", '100%', 800)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/sizing/max-width.html", '100%', 1200)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/tables/table.html", '100%', 1000)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/backgrounds/backgrounds1.html", '100%', 700)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/backgrounds/backgrounds2.html", '100%', 700)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/values/color.html", '100%', 1000)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/values/length.html", '100%', 1000)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/values/position.html", '100%', 800)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/writing-modes/writing-mode.html", '100%', 800)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/writing-modes/logical-width-height.html", '100%', 1100)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/writing-modes/logical-mbp.html", '100%', 1100)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/flexbox/flexbox1.html", '100%', 700)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/flexbox/flexbox2.html", '100%', 800)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/flexbox/flexbox3.html", '100%', 800)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/flexbox/flexbox4.html", '100%', 1100)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/float/float1.html", '100%', 900)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/float/float2.html", '100%', 800)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/float/float3.html", '100%', 800)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/grid/grid1.html", '100%', 700)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/grid/grid2.html", '100%', 900)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/grid/grid3.html", '100%', 800)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/grid/grid4.html", '100%', 2000)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/multicol/multicol1.html", '100%', 1000)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/multicol/multicol2.html", '100%', 1000)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/multicol/multicol3.html", '100%', 1000)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/position/position1.html", '100%', 1000)}}
{{EmbedGHLiveSample("css-examples/learn/tasks/position/position2.html", '100%', 1300)}}

Motivation

Motivation is described in the project issue.

Related issues and pull requests

@bsmth bsmth requested a review from a team as a code owner November 7, 2024 09:45
@bsmth bsmth requested review from estelle and removed request for a team November 7, 2024 09:45
@github-actions github-actions bot added Content:Learn:CSS Learning area CSS docs size/xl [PR only] >1000 LoC changed labels Nov 7, 2024
Copy link
Contributor

github-actions bot commented Nov 7, 2024

Preview URLs (16 pages)
External URLs (48)

URL: /en-US/docs/Learn/CSS/Building_blocks/Sizing_tasks
Title: Test your skills: Sizing


URL: /en-US/docs/Learn/CSS/Building_blocks/Selectors/Selectors_Tasks
Title: Test your skills: Selectors


URL: /en-US/docs/Learn/CSS/Building_blocks/Cascade_tasks
Title: Test your skills: The Cascade


URL: /en-US/docs/Learn/CSS/Building_blocks/Box_Model_Tasks
Title: Test your skills: The box model


URL: /en-US/docs/Learn/CSS/Building_blocks/Overflow_Tasks
Title: Test your skills: Overflow


URL: /en-US/docs/Learn/CSS/Building_blocks/Values_tasks
Title: Test your skills: Values and units


URL: /en-US/docs/Learn/CSS/Building_blocks/Tables_tasks
Title: Test your skills: Tables


URL: /en-US/docs/Learn/CSS/Building_blocks/Test_your_skills_backgrounds_and_borders
Title: Test your skills: Backgrounds and borders


URL: /en-US/docs/Learn/CSS/Building_blocks/Writing_Modes_Tasks
Title: Test your skills: Writing modes and logical properties


URL: /en-US/docs/Learn/CSS/Building_blocks/Images_tasks
Title: Test your skills: Images and form elements


URL: /en-US/docs/Learn/CSS/CSS_layout/Flexbox_skills
Title: Test your skills: Flexbox


URL: /en-US/docs/Learn/CSS/CSS_layout/Multicol_skills
Title: Test your skills: Multicol


URL: /en-US/docs/Learn/CSS/CSS_layout/Position_skills
Title: Test your skills: Positioning


URL: /en-US/docs/Learn/CSS/CSS_layout/Floats_skills
Title: Test your skills: Floats


URL: /en-US/docs/Learn/CSS/CSS_layout/Grid_skills
Title: Test your skills: Grid

(comment last updated: 2024-11-07 15:35:10)

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @bsmth. I've left you a few comments here too, but nothing much.

@bsmth
Copy link
Member Author

bsmth commented Nov 7, 2024

Thank you! Should be ready for another once-over 🔬

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Merging!

@chrisdavidmills chrisdavidmills merged commit c507c55 into mdn:main Nov 8, 2024
8 checks passed
@bsmth bsmth deleted the css-examples-learn-tasks branch November 8, 2024 14:56
@bsmth
Copy link
Member Author

bsmth commented Nov 8, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Learn:CSS Learning area CSS docs size/xl [PR only] >1000 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants