Mark normal and reset as non-standard values for zoom property
#36732
+13
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated the `zoom` property documentation to clarify that `normal` and `reset` are non-standard values. - Included relevant references and links to CSS specifications.
github-actions
bot
added
Content:CSS
|
Preview URLs External URLs (1)URL:
(comment last updated: 2024-11-13 04:27:49) |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
estelle
reviewed
Nov 13, 2024
files/en-us/web/css/zoom/index.md
Outdated
| @@ -59,7 +59,7 @@ zoom: unset; | |||
|
|
|||
| ```plain | |||
| zoom = | |||
| normal | reset | <number> | <percentage> | |||
| normal | reset | <number> | <percentage> /* Non-standard values */ | |||
There was a problem hiding this comment.
we can get rid of all the text here, and use the macro:
{{csssyntax}}
this will then include what is included in the spec (and not the non-standard values)
There was a problem hiding this comment.
Thanks for your suggestions, I learn a lot.
files/en-us/web/css/zoom/index.md
Outdated
| - `reset` | ||
| - : Do not (de)magnify this element if the user applies non-pinch-based zooming (e.g. by pressing <kbd>Ctrl</kbd> \- <kbd>-</kbd> or <kbd>Ctrl</kbd> \+ <kbd>+</kbd> keyboard shortcuts) to the document. **Do not use** this value, _use the standard `unset` value instead_. | ||
| - : Do not (de)magnify this element if the user applies non-pinch-based zooming (e.g. by pressing <kbd>Ctrl</kbd> \- <kbd>-</kbd> or <kbd>Ctrl</kbd> \+ <kbd>+</kbd> keyboard shortcuts) to the document. **Non-standard.** Consider using `unset` instead. |
There was a problem hiding this comment.
Suggest listing the valid values (percent and number) first, then adding a paragraph that reads something to the effect of:
"Non-standard keyword values include reset and normal. These values are not recommended. Check browser compatibility data:"
and putting the edited non-standard values after.
estelle
reviewed
Nov 13, 2024
estelle
reviewed
Nov 13, 2024
update `reset` description Co-authored-by: Estelle Weyl <[email protected]>
update `normal` description Co-authored-by: Estelle Weyl <[email protected]>
update see also Co-authored-by: Estelle Weyl <[email protected]>
apply suggestions on the order of Values and the content of Formal syntax
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Estelle Weyl <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
tiny format change Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zoomproperty documentation to clarify thatnormalandresetare non-standard values.Description
Revises the
zoomproperty documentation to indicate that the valuesnormalandresetare non-standard and deprecated.Provides clarification on the usage of these values and recommends using
unsetinstead.Motivation
To improve the clarity of the
zoomproperty's documentation, ensuring that users understand thatnormalandresetare non-standard and discouraged for use.Additional details
https://developer.mozilla.org/en-US/docs/Web/CSS/zoom
Related issues and pull requests
Fixes #36720.