Skip to content

docs: Add warning and clarify named form access via document.formName(#39891) #40001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 27, 2025

Conversation

Shrinivassab
Copy link
Contributor

Description

Documented named form access on document object and discouraged its usage.

Motivation

Clarifies confusing or undocumented behavior; resolves #39891.

Additional details

Related issues and pull requests

#39986

@Shrinivassab Shrinivassab requested a review from a team as a code owner June 20, 2025 00:45
@Shrinivassab Shrinivassab requested review from sideshowbarker and removed request for a team June 20, 2025 00:45
@github-actions github-actions bot added Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed labels Jun 20, 2025
Copy link
Contributor

github-actions bot commented Jun 20, 2025

Preview URLs (6 pages)
Flaws (11)

Note! 4 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/Document
Title: Document
Flaw count: 9

  • macros:
    • Can't resolve /en-US/docs/Web/API/Document/xmlStandalone
    • Can't resolve /en-US/docs/Web/API/Document/captureEvents
    • Can't resolve /en-US/docs/Web/API/Document/getBoxQuads
    • Can't resolve /en-US/docs/Web/API/Document/releaseEvents
    • Can't resolve /en-US/docs/Web/API/Document/queryCommandIndeterm
    • and 4 more flaws omitted

URL: /en-US/docs/Web/API/Window
Title: Window
Flaw count: 2

  • macros:
    • Macro produces link /en-US/docs/Web/API/HTMLElement/invalid_event which is a redirect
    • Macro produces link /en-US/docs/Web/API/Element/select_event which is a redirect

(comment last updated: 2025-06-27 04:18:55)

@Josh-Cena Josh-Cena requested a review from a team as a code owner June 20, 2025 08:49
@Josh-Cena Josh-Cena requested review from dipikabh and removed request for a team June 20, 2025 08:49
@github-actions github-actions bot added Content:HTML Hypertext Markup Language docs merge conflicts 🚧 [PR only] labels Jun 20, 2025
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 [PR only] label Jun 24, 2025
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@sideshowbarker sideshowbarker removed their request for review June 24, 2025 05:45
@dipikabh dipikabh requested a review from hamishwillee June 24, 2025 14:27
@dipikabh
Copy link
Contributor

Hi Hamish, would you mind reviewing this PR? On an initial look, I'm not entirely sure that the new "Named properties" section fits under "Extensions for HTMLDocument" in files/en-us/web/api/document/index.md. But I'm also not too familiar with the conventions in the API land. Could you take a look?

@Josh-Cena
Copy link
Member

There are no conventions for this. I just made it up.

@hamishwillee
Copy link
Collaborator

There are no conventions for this. I just made it up.

Thanks @dipikabh . IMO this is good. I like @Josh-Cena convention. I added a minor query and I'm going to fixup the layout of that first item while we're here, because it annoys me.

hamishwillee and others added 2 commits June 27, 2025 14:05
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Shrinivassab @Josh-Cena - Works for me. Thank you.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@Josh-Cena Josh-Cena merged commit 4101830 into mdn:main Jun 27, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:HTML Hypertext Markup Language docs Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Named forms are available as properties on document
4 participants